Skip to content

Conversation

@coodos
Copy link
Contributor

@coodos coodos commented Oct 28, 2025

Description of change

remove, chat updation handlers from services.

Issue Number

Type of change

  • Fix (a change which fixes an issue)

How the change has been tested

Change checklist

  • I have ensured that the CI Checks pass locally
  • I have removed any unnecessary logic
  • My code is well documented
  • I have signed my commits
  • My code follows the pattern of the application
  • I have self reviewed my code

Summary by CodeRabbit

  • Bug Fixes
    • Updated the message handling workflow to prevent automatic updates to chat timestamps when messages are sent.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 28, 2025

Walkthrough

The pull request removes chat timestamp update logic from message operations in ChatService and MessageService, eliminating automatic Chat.updatedAt updates when messages are sent or created. Minor formatting changes are also applied to sorting and return checks.

Changes

Cohort / File(s) Summary
Message timestamp decoupling
platforms/pictique-api/src/services/ChatService.ts, platforms/pictique-api/src/services/MessageService.ts
Removed code that updates Chat.updatedAt timestamp after sending/creating messages. ChatService.sendMessage no longer re-saves chat with updated timestamp; MessageService.createMessage no longer fetches and persists chat updatedAt. Includes whitespace formatting adjustments.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • Areas requiring attention:
    • Verify that removing Chat.updatedAt updates during message operations doesn't break chat ordering, sorting, or UI functionality that may depend on this timestamp
    • Confirm whether chat timestamp updates should be handled elsewhere or are intentionally deprecated
    • Assess any database queries or features that may rely on Chat.updatedAt reflecting message activity

Possibly related PRs

  • feat: chat pagination #378: Modifies the same Chat.updatedAt update behavior during message creation/send operations in opposite direction—related PR adds/relies on these timestamps while this PR removes them.

Poem

🐰 Time stands still in chats so bright,
Messages sent without timestamp's flight,
Decoupled now, the old links break free,
Chat metadata flows more gently, you see! ✨

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (2 passed)
Check name Status Explanation
Title Check ✅ Passed The pull request title "hotfix: remove chat updation from services right after sending a message" directly and clearly summarizes the main change in the changeset. The title accurately reflects the functional changes shown in both ChatService.ts and MessageService.ts, where code that updated the chat's updatedAt timestamp after sending a message has been removed. The title is concise, specific, and avoids vague language or noise.
Description Check ✅ Passed The pull request description follows the required template structure with all main sections present: Description of change, Issue Number, Type of change, How the change has been tested, and Change checklist. The type of change is appropriately marked as "Fix." However, the description is mostly skeletal with the "Issue Number" and "How the change has been tested" sections left empty, and all checklist items remain unchecked. While the description is not comprehensively filled out, it does provide the essential framework and core information about the change type and general intent.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch hotfix/pictique-messages-vanishing

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6f1f4c4 and 1c70e32.

📒 Files selected for processing (2)
  • platforms/pictique-api/src/services/ChatService.ts (3 hunks)
  • platforms/pictique-api/src/services/MessageService.ts (0 hunks)
💤 Files with no reviewable changes (1)
  • platforms/pictique-api/src/services/MessageService.ts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coodos coodos merged commit 7e389c0 into main Oct 28, 2025
0 of 4 checks passed
@coodos coodos deleted the hotfix/pictique-messages-vanishing branch October 28, 2025 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants