Skip to content

Fix/favicons #463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 24, 2025
Merged

Fix/favicons #463

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
22b8217
fix: dreamsync favicons
sosweetham Nov 24, 2025
467ae7f
fix: ereputation favicons
sosweetham Nov 24, 2025
6cdec35
fix: ereputation favicons
sosweetham Nov 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file added platforms/dreamSync/client/public/android-chrome-192x192.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added platforms/dreamSync/client/public/android-chrome-512x512.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added platforms/dreamSync/client/public/apple-touch-icon.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added platforms/dreamSync/client/public/favicon-16x16.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added platforms/dreamSync/client/public/favicon-32x32.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added platforms/dreamSync/client/public/favicon.ico
View file
Open in desktop
Binary file not shown.
1 change: 1 addition & 0 deletions platforms/dreamSync/client/public/site.webmanifest
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
{"name":"","short_name":"","icons":[{"src":"/android-chrome-192x192.png","sizes":"192x192","type":"image/png"},{"src":"/android-chrome-512x512.png","sizes":"512x512","type":"image/png"}],"theme_color":"#ffffff","background_color":"#ffffff","display":"standalone"}
5 changes: 5 additions & 0 deletions platforms/eReputation/client/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,11 @@
<head>
<meta charset="UTF-8" />
<meta name="viewport" content="width=device-width, initial-scale=1.0, maximum-scale=1" />
<link rel="icon" type="image/x-icon" href="/favicon.ico" />
<link rel="icon" type="image/png" sizes="16x16" href="/favicon-16x16.png" />
<link rel="icon" type="image/png" sizes="32x32" href="/favicon-32x32.png" />
<link rel="apple-touch-icon" sizes="180x180" href="/apple-touch-icon.png" />
<link rel="manifest" href="/site.webmanifest" />
</head>
<body>
<div id="root"></div>
Expand Down
Binary file added platforms/eReputation/client/public/android-chrome-192x192.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added platforms/eReputation/client/public/android-chrome-512x512.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added platforms/eReputation/client/public/apple-touch-icon.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added platforms/eReputation/client/public/favicon-16x16.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added platforms/eReputation/client/public/favicon-32x32.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added platforms/eReputation/client/public/favicon.ico
View file
Open in desktop
Binary file not shown.
1 change: 1 addition & 0 deletions platforms/eReputation/client/public/site.webmanifest
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
{"name":"","short_name":"","icons":[{"src":"/android-chrome-192x192.png","sizes":"192x192","type":"image/png"},{"src":"/android-chrome-512x512.png","sizes":"512x512","type":"image/png"}],"theme_color":"#ffffff","background_color":"#ffffff","display":"standalone"}
Copy link
Contributor

@coderabbitai coderabbitai bot Nov 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

🧩 Analysis chain

Missing icon assets and empty PWA application names.

The manifest references icon files (/android-chrome-192x192.png and /android-chrome-512x512.png) that are not present in the PR diff. Additionally, both name and short_name are empty strings, which will degrade the PWA experience (install prompts, add-to-home-screen dialogs, etc. won't display an app name).

Please verify the following:

  1. Are the actual PNG icon files (android-chrome-192x192.png and android-chrome-512x512.png) included in this PR or a separate commit? They must be present in the platforms/eReputation/client/public/ directory.

  2. Fill in meaningful values for name and short_name to enable proper PWA functionality:

-{"name":"","short_name":"","icons":[...
+{"name":"eReputation","short_name":"eRep","icons":[...

🏁 Script executed:

#!/bin/bash
# Check if icon files exist in the eReputation public directory
echo "=== Checking for icon files ==="
find platforms/eReputation/client/public -name "*android-chrome*" -type f 2>/dev/null || echo "No android-chrome files found"

# Check what files exist in the public directory
echo ""
echo "=== Contents of platforms/eReputation/client/public/ ==="
ls -la platforms/eReputation/client/public/ 2>/dev/null || echo "Directory not found or cannot list"

# Check if there are any PNG files in the directory
echo ""
echo "=== PNG files in eReputation public directory ==="
find platforms/eReputation/client/public -name "*.png" -type f 2>/dev/null || echo "No PNG files found"

# Look for other manifest files
echo ""
echo "=== Other manifest or config files in eReputation client ==="
find platforms/eReputation/client -name "*.json" -o -name "manifest*" -o -name "*icon*" 2>/dev/null | head -20

Length of output: 1446

🏁 Script executed:

#!/bin/bash
# Check site.webmanifest file content and related PWA files
echo "=== site.webmanifest content ==="
cat platforms/eReputation/client/public/site.webmanifest 2>/dev/null || echo "File not found"

echo ""
echo "=== Check for favicon and other icon-related files ==="
ls -la platforms/eReputation/client/public/ | grep -E "(favicon|icon)" || echo "No favicon/icon files listed"

Length of output: 624

🏁 Script executed:

#!/bin/bash
# Search for any references to the icon files in the codebase
echo "=== References to android-chrome-192x192 ==="
rg "android-chrome-192x192" --type-list 2>/dev/null | head -5 || echo "ripgrep search"
rg "android-chrome-192x192" 2>/dev/null || echo "No references found"

echo ""
echo "=== References to android-chrome-512x512 ==="
rg "android-chrome-512x512" 2>/dev/null || echo "No references found"

Length of output: 1354

🏁 Script executed:

#!/bin/bash
# Check git status or recent changes to understand what was added
echo "=== Git log for site.webmanifest ==="
git log --oneline --follow -- "platforms/eReputation/client/public/site.webmanifest" 2>/dev/null | head -5 || echo "Git log not available"

echo ""
echo "=== Check for any asset files added ==="
git diff --name-status HEAD~ -- "platforms/eReputation/client/public/*.png" 2>/dev/null || echo "Git diff not available for PNGs"

Length of output: 444

🏁 Script executed:

#!/bin/bash
# Check if this is a new file or modification
echo "=== File status in git ==="
git status -- "platforms/eReputation/client/public/site.webmanifest" 2>/dev/null || echo "Git status not available"

echo ""
echo "=== Check diff for site.webmanifest ==="
git show HEAD:"platforms/eReputation/client/public/site.webmanifest" 2>/dev/null && echo "File exists in current HEAD" || echo "File is new or not in HEAD"

Length of output: 421

🏁 Script executed:

#!/bin/bash
# Look for PWA setup files (favicon, icons directory, etc.)
echo "=== Full directory structure of platforms/eReputation/client ==="
find platforms/eReputation/client -type f \( -name "*.png" -o -name "*.jpg" -o -name "*.ico" -o -name "*icon*" -o -name "*favicon*" \) 2>/dev/null

echo ""
echo "=== Check public directory contents ==="
find platforms/eReputation/client/public -type f 2>/dev/null | sort

Length of output: 836

🏁 Script executed:

#!/bin/bash
# Check git diff to see what was added in this PR
echo "=== Git diff for site.webmanifest (added file) ==="
git diff --no-index /dev/null platforms/eReputation/client/public/site.webmanifest 2>/dev/null | head -20 || git show :"platforms/eReputation/client/public/site.webmanifest" 2>/dev/null || echo "Cannot show diff"

Length of output: 595

🌐 Web query:

PWA manifest empty name short_name field requirements valid

💡 Result:

Short answer

  • Neither name nor short_name is strictly required by the Web App Manifest spec — both are optional. However if both are missing or empty, user agents may fallback (e.g., use document title or a default like "Untitled") and installability checks (e.g., Lighthouse / Chrome) expect a valid name/short_name to consider the manifest acceptable. [1][2][3]

Details / practical guidance

  • Spec: the manifest algorithm processes "name" and "short_name"; if they are missing, empty, or wrong type a UA MAY fallback to the document (or assign a default). So an empty string is treated like missing for fallback purposes. [1]
  • MDN: both members exist to provide the app’s display names; browsers use short_name where space is constrained. MDN documents them as optional but notes PWAs typically require some name for install UX. [2]
  • Tooling: Lighthouse and other validators require a “valid name/short_name” (or at least one of them) to pass installability / “can prompt to install” audits. If you want consistent install behavior and to satisfy validators, include either name or short_name (preferably both, with short_name ≲12 chars). [3]

Recommendation

  • Provide a non-empty "name" (and a short "short_name" for compact UIs). If you intentionally leave them out or set them to "" expect fallbacks and possible Lighthouse/installability failures. [1][2][3]

Sources
[1] W3C Web Application Manifest spec — processing of name/short_name and fallback behavior.
[2] MDN Web Docs — manifest name and short_name reference.
[3] Lighthouse / Chrome installability guidance (manifest must have valid name/short_name for install prompts).

Icon files are present; fill in empty PWA application names.

The icon files (android-chrome-192x192.png and android-chrome-512x512.png) are correctly included in this PR and were added together with the manifest. However, both name and short_name remain empty strings. While technically valid per the W3C Web App Manifest spec, empty values will cause browsers to fall back to document title or defaults, and will fail Lighthouse installability checks needed for proper install prompts and add-to-home-screen dialogs.

Add meaningful values for name and short_name:

-{"name":"","short_name":"","icons":[...
+{"name":"eReputation","short_name":"eRep","icons":[...
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
{"name":"","short_name":"","icons":[{"src":"/android-chrome-192x192.png","sizes":"192x192","type":"image/png"},{"src":"/android-chrome-512x512.png","sizes":"512x512","type":"image/png"}],"theme_color":"#ffffff","background_color":"#ffffff","display":"standalone"}
{"name":"eReputation","short_name":"eRep","icons":[{"src":"/android-chrome-192x192.png","sizes":"192x192","type":"image/png"},{"src":"/android-chrome-512x512.png","sizes":"512x512","type":"image/png"}],"theme_color":"#ffffff","background_color":"#ffffff","display":"standalone"}
🤖 Prompt for AI Agents 
In platforms/eReputation/client/public/site.webmanifest around lines 1 to 1, the
manifest currently has empty "name" and "short_name" properties which prevents
proper PWA installability; update those two fields with meaningful values (set
"name" to the full application name and "short_name" to a concise label suitable
for homescreen display, typically <=12 characters) and keep the rest of the
manifest unchanged so browsers and Lighthouse can recognize the app for install
prompts.