Merged
Conversation
NicolasDorier
force-pushed
the
additional-cleanup
branch
5 times, most recently
from
be10caa to
2fe93f4
Compare
NicolasDorier
force-pushed
the
additional-cleanup
branch
from
2fe93f4 to
f54d823
Compare
NicolasDorier
added a commit
that referenced
this pull request
May 15, 2025
* backport to 7.x * Fix tests (#1270) * add RemoveSignatures method --------- Co-authored-by: Hugo ESQUIBET <hesquibet@ripple.com> Co-authored-by: Nicolas Dorier <nicolas.dorier@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up of #1269
Since it isn't possible to properly deserialize a transaction without input (and those can't exists on the network), this PR forbidden the serialization of transactions without input.
I added
BitcoinStream.AllowNoInputsto still allow this for back compatibility reason (fundrawtransactionfrom core) or because it is acceptable, as the serialized bytes will never be read (calculation of the hash or size)