feat: Add video playback support for video songs#2861
Draft
kairosci wants to merge 7 commits intoMetrolistGroup:mainfrom
Draft
feat: Add video playback support for video songs#2861kairosci wants to merge 7 commits intoMetrolistGroup:mainfrom
kairosci wants to merge 7 commits intoMetrolistGroup:mainfrom
Conversation
66e0703 to
e321811
Compare
Member
|
Feedback: It gives us all a black screen |
Member
f203d2e to
7e33307
Compare
Member
|
No video player shown yet! |
-Add VideoPlayer component using Media3 PlayerView - Add toggle button in Now Playing header - Add EnableVideoPlaybackKey preference (defaults to true) - Add appearance settings option for video playback - Implement video streaming support in YTPlayerUtils (muxed formats) - Pass video preference from MusicService to streaming layer - Add videocam/videocam_off icons for toggle button
7e33307 to
ee2b71b
Compare
Contributor
Author
|
I just discovered that the app only fetched audio, so I need to fetch mixed data. When it's ready, I'll mark it as ready. |
Collaborator
Just letting you know, in order to get ada
If you want adaptive streaming, above 720p you can use built in MergingMediaSource, TVHTML is a good primary client too. Might need to apply PoToken and n transform same that we are using for web remix. I think so. Could be wrong. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Video songs display only static thumbnails instead of playing video content.
Cause
The player lacks video playback integration. While the codebase tracks
isVideoSongmetadata, the UI only renders static images in the thumbnail area for all media types.Solution
Testing
Feature builds successfully. Requires device testing with video songs from YouTube Music to verify playback functionality, performance, and battery impact.
Closes no specific issue (new feature implementation)