feat(downloads): add format picker and custom download path#2871
Open
alltechdev wants to merge 5 commits intomainfrom
Open
feat(downloads): add format picker and custom download path#2871alltechdev wants to merge 5 commits intomainfrom
alltechdev wants to merge 5 commits intomainfrom
Conversation
alltechdev
changed the title
- Add format picker dialog when downloading songs (shows bitrate/codec) - Add custom download path support via SAF (Storage Access Framework) - Export downloads to user-selected folder with Artist/Title structure - Integrate Bento4 native library for M4A metadata embedding (cover art, title, artist, album, year) - Add "swap download" option to re-download with different quality - Add database schema migration for downloadUri tracking - Only embed metadata for M4A files >= 128kbps (low bitrate compatibility) - Show metadata badge on format options that support embedding
- Use downloadUri directly for playback instead of ExoPlayer downloadCache to prevent format mismatch errors (MatroskaExtractor parsing M4A data) - Check targetItag before cache in DownloadUtil to respect user format selection - Clear playerCache when specific format requested to ensure fresh fetch - Fix URL cache expiry check (was using wrong comparison operator) - Reorder ExtractorsFactory: FragmentedMp4Extractor first for M4A files - Add detailed logging for download and cache resolution debugging
alltechdev
force-pushed
the
feat/downloads_path-format
branch
from
cc6fadd to
bac1c87
Compare
Collaborator
Author
|
Just saying, guys, feel free to completely ignore this one 😁 I'm aware it's a ridiculous amount of code, I just really like the functionality, especially bento4. |
Can you PLEASE tell me how long it took you to write almost 80k lines of code. I bet it was like hell to debug bugs. |
Member
|
I need to review 80,000 lines!!! 🤣 |
- Move Bento4 library and JNI wrapper to metrolist-coverart-lib repository - Replace embedded code with git submodule reference - This reduces main repository size by ~77,000 lines - Library can now be independently versioned and updated Submodule: https://github.com/MetrolistGroup/metrolist-coverart-lib
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
New Features
Bug Fixes
Technical
Test plan