feat(lyrics): add hindi/gurmukhi romanization and main text swap option#2872
Closed
adrielGGmotion wants to merge 1 commit intoMetrolistGroup:mainfrom
Closed
feat(lyrics): add hindi/gurmukhi romanization and main text swap option#2872adrielGGmotion wants to merge 1 commit intoMetrolistGroup:mainfrom
adrielGGmotion wants to merge 1 commit intoMetrolistGroup:mainfrom
Conversation
This commit introduces Romanization support for Hindi (Devanagari) and Punjabi (Gurmukhi) scripts. This was necessary because user feedback identified songs containing mixed scripts (both Hindi and Punjabi) that were not being fully romanized. Key changes: - Added 'LyricsRomanizedAsMainKey' to allow swapping romanized text to the main view. - Implemented 'romanizeHindi' and 'romanizeGurmukhi' in LyricsUtils. - Updated Settings UI to include these new languages and restored previously missing Japanese/Korean options. - Organized Romanization settings with proper 'General' and 'Cyrillic' headers.
Contributor
Author
|
Closing cause build failed, it did indeed build on my environment so i'll check the cause |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements Hindi (Devanagari) and Punjabi (Gurmukhi) romanization support, addressing the main request in #2851. It also includes an enhancement requested in the comments to allow displaying romanized lyrics as the main text.
Key Changes
romanizeHindifor Devanagari script (includes fixes for stray modifiers/symbols).romanizeGurmukhifor Punjabi script (added to handle songs with mixed Hindi/Punjabi lyrics).Related Issue
Closes #2851