Skip to content

fix(core/anchor): use top/bottom instead of calc height for anchor ba…#387

Merged
travor20814 merged 2 commits intov2from
feature/anchor
Mar 16, 2026
Merged

fix(core/anchor): use top/bottom instead of calc height for anchor ba…#387
travor20814 merged 2 commits intov2from
feature/anchor

Conversation

@FantasyQ
Copy link
Collaborator

Copilot AI review requested due to automatic review settings March 11, 2026 06:23
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Mar 11, 2026

Deploying mezzanine-ui with  Cloudflare Pages  Cloudflare Pages

Latest commit: 9bfce7d
Status: ✅  Deploy successful!
Preview URL: https://43627b51.mezzanine-ui.pages.dev
Branch Preview URL: https://feature-anchor.mezzanine-ui.pages.dev

View logs

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adjusts the Anchor item indicator bar styling so it uses top/bottom positioning instead of a calculated height, aligning with the requested focus-state visual behavior update.

Changes:

  • Replace height: calc(...) with top + bottom insets (and height: auto) for the anchor item ::before bar.
  • Extend the bar to full height (top: 0; bottom: 0) for active and focus-visible states.
  • Add transitions for top/bottom to animate the bar extent change.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

@FantasyQ FantasyQ force-pushed the feature/anchor branch 3 times, most recently from 210c5fa to 289d22f Compare March 13, 2026 06:29
@FantasyQ FantasyQ changed the title [WIP] fix(core/anchor): use top/bottom instead of calc height for anchor ba… fix(core/anchor): use top/bottom instead of calc height for anchor ba… Mar 13, 2026
@FantasyQ FantasyQ requested a review from travor20814 March 13, 2026 11:11
@FantasyQ FantasyQ changed the title fix(core/anchor): use top/bottom instead of calc height for anchor ba… [WIP] fix(core/anchor): use top/bottom instead of calc height for anchor ba… Mar 13, 2026
@FantasyQ FantasyQ removed the request for review from travor20814 March 13, 2026 11:14
@FantasyQ FantasyQ changed the base branch from main to v2 March 13, 2026 11:15
@FantasyQ FantasyQ changed the title [WIP] fix(core/anchor): use top/bottom instead of calc height for anchor ba… fix(core/anchor): use top/bottom instead of calc height for anchor ba… Mar 13, 2026
@FantasyQ FantasyQ requested a review from travor20814 March 13, 2026 11:15
@travor20814 travor20814 merged commit c8581fc into v2 Mar 16, 2026
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants