Add option to fix broken terminfo detection on case insensitive FSes#124
Open
midchildan wants to merge 1 commit intoMic92:mainfrom
Open
Add option to fix broken terminfo detection on case insensitive FSes#124midchildan wants to merge 1 commit intoMic92:mainfrom
midchildan wants to merge 1 commit intoMic92:mainfrom
Conversation
38c0534 to
c7cd8af
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Terminfo databases can become corrupted on macOS hosts due to the following reasons:
Nix attempts to resolve these case conflicts by renaming the problematic files. However, this breaks terminal functionality since the affected terminfo entries become undetectable by software that uses them.
Example of affected directories:
An example of the resulting error:
To mitigate case conflicts, this PR makes the guest system copy terminfo entries from directories with lowercase letters to their uppercase counterparts. This ensures that when the Nix store is case-insensitive, access to
x/xterm-256colorwill redirect to its copy,X/xterm-256color. Conversely, when the Nix store is case-sensitive,x/xterm-256colorcan still be accessed directly.Closes #101