Conversation
|
Implementation looks good so far. As you already put it out a test would be nice and also documentation in the README. |
|
6fe1fee fixes my caller error because the branch also there is a bug in rev. when i call then nix-review fetches the master branch of https://github.com/delroth/nixpkgs but the fork is out-of-sync with NixOS/nixpkgs, so as base commit i get delroth/nixpkgs@045a4a4 (2018-10-13) nix-review should get the |
|
now this works this PR still needs some polish ... |
nixpkgs_review/review.py
Outdated
|
|
||
| cache_size_limit = 200 * 1000 * 1000, # 200MB (default: 1GB) | ||
|
|
||
| cache = diskcache.Cache(cache_dir, size_limit = cache_size_limit) |
There was a problem hiding this comment.
I would prefer to have no dependencies outside the python stdlib in nixpkgs-review. There is for example: https://docs.python.org/3/library/dbm.html and one could just keep the last 100 evals...
There was a problem hiding this comment.
eval cache is now a "stupid file cache" with *.xml.gz files (todo: garbage collect)
i think it's useful and stable enough to make eval-cache default on
fix #271
mostly copy-paste of the pr command
prcommand