Draft
Conversation
This was referenced Dec 5, 2025
corngood
force-pushed
the
nixpkgs-args
branch
2 times, most recently
from
1c5639e to
0465e79
Compare
corngood
commented
Dec 9, 2025
| allowSubstitutes = false; | ||
| dontWrapQtApps = true; | ||
| packages = if builtins.length attrs > 50 then [ env ] else attrs; | ||
| packages = [ env ]; |
Contributor
Author
There was a problem hiding this comment.
This sneaky change is here because it bypasses splicing. packages goes into nativeBuildInputs, which applies splicing if attrs is passed in directly. In a cross scenario we likely want the host packages.
corngood
force-pushed
the
nixpkgs-args
branch
from
0465e79 to
96d37a8
Compare
corngood
force-pushed
the
nixpkgs-args
branch
from
96d37a8 to
ffaa811
Compare
Contributor
|
I may have done mostly the same as you in #608 |
Contributor
Author
|
@hatch01 I think this one's a little more general, but yours would probably do for most of the cases I was hoping to use this for. I can rebase this and test it, but it would be nice to get some guidance from maintainers. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is my attempt at making nixpkgs args customisable. I mostly want this for testing PRs that fix cross-compilation of packages (using
crossSystem).Builddirnow requires aBuildenvso it can initNIX_PATHin one place<nixpkgs>is now a wrapper, which works in the shell, but may be confusing/breaking for people assuming that nixpkgs/ is the same thingextra-nixpkgs-confighandling by combining it with args (unless we just want to remove it)Feedback would be appreciated.
Fixes: #375