feat(Google Slides): Add support for Google Slides#114
Open
reachtokish wants to merge 2 commits intoMichaelDeBoey:mainfrom
Open
feat(Google Slides): Add support for Google Slides#114reachtokish wants to merge 2 commits intoMichaelDeBoey:mainfrom
reachtokish wants to merge 2 commits intoMichaelDeBoey:mainfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #114 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 16 17 +1
Lines 215 227 +12
Branches 27 27
=========================================
+ Hits 215 227 +12 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
MichaelDeBoey
added
the
⚙︎ Google Slides
MichaelDeBoey
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What: Added Google Slides support
Why: Fixes issue #96
How: Added GoogleSlides.js and necessary tests
Checklist:
Hi @MichaelDeBoey, I have raised this PR so that this plugin can support to embed Google Slides. I have written the required codes for that and also added tests. Though
npm run test:updatefailing and throwing errorJest: "global" coverage threshold for branches (100%) not met: 99.16%- like this. I think I could not cover tests for all the codes.Kindly check whole the things and please let me know what else I have to do to make it all fix. I'm quite new in gatsby and also I've never used this plugin but wanted to give a try.
Thanks!!