Added height and width props to Twitch service#198
Open
crutchcorn wants to merge 1 commit intoMichaelDeBoey:mainfrom
Open
Added height and width props to Twitch service#198crutchcorn wants to merge 1 commit intoMichaelDeBoey:mainfrom
crutchcorn wants to merge 1 commit intoMichaelDeBoey:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What: Add the ability to pass custom height and width to Twitch embeds
Why: Consumers of plugin may need to customize the height of the embed (such as my project)
How: Add option to render function, added tests, updated documentation
Checklist:
Related issue: #144
Related PR: #151
I'd be happy to add this logic to every other service with hardcoded options if that would be helpful for the project