Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Jan 5, 2026

  • Rename FileLoggerFactory to LoggerFactory
    • Create new LoggerFactory.cs with renamed class
    • Update class name from FileLoggerFactory to LoggerFactory
    • Update XML documentation to reflect more general purpose
    • Delete old FileLoggerFactory.cs file
    • Update RemoteDebuggerLauncher.csproj reference
    • Update readme.md documentation

The factory is now named LoggerFactory to better reflect that it can configure multiple types of loggers, not just file-based ones. This makes the naming more extensible for future enhancements.

Original prompt

This section details on the original issue you should resolve

<issue_title>Debug Logfile</issue_title>
<issue_description>As a user, I want detailed information on what the extension is doing, in case I have issues.
As a developer, I want detailed diagnostics to find root causes

The logfile shall use the same logging levels as the .NET ILogger abstractions

Configuration

  • The logfile feature can be turned on in the extension options
  • The Logging level 'None' turns the logging feature off

Location

  • The log files shall be created under %localappdata%\RemoteDebuggerLauncher\Logfiles

Implementation

  • The Logger implementation shall rely on similar concepts as the .NET ILogger infrastructure
  • The Logger client shall be injectable using MEF
    </issue_description>

Comments on the Issue (you are @copilot in this section)


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

@MichaelKoster70
Copy link
Owner

@copilot do not implement the abstractions - use Microsoft.Extensions.Logging directly

…pression with traditional switch

Co-authored-by: MichaelKoster70 <[email protected]>
Copilot AI changed the title [WIP] Add debug logfile feature with logging levels Add diagnostic logging infrastructure with file-based output Jan 5, 2026
Copilot AI requested a review from MichaelKoster70 January 5, 2026 07:39
Copy link
Contributor Author

Copilot AI commented Jan 5, 2026

@copilot do not implement the abstractions - use Microsoft.Extensions.Logging directly

Done in commit 79e424e. I've replaced the custom logging abstractions with Microsoft.Extensions.Logging.Abstractions (v6.0.0). All custom ILogger, ILoggerFactory, and LogLevel implementations have been removed and replaced with the official Microsoft package interfaces.

Copilot AI changed the title Add diagnostic logging infrastructure with file-based output Add diagnostic logging infrastructure using Microsoft.Extensions.Logging Jan 5, 2026
@MichaelKoster70
Copy link
Owner

@copilot Use SeriLog "Serilog.Extensions.Logging" to implement the file logger

Copy link
Contributor Author

Copilot AI commented Jan 5, 2026

@copilot Use SeriLog "Serilog.Extensions.Logging" to implement the file logger

Done in commit 2c84e73. I've replaced the custom FileLogger implementation with Serilog. The implementation now uses:

  • Serilog (v2.12.0) for structured logging
  • Serilog.Extensions.Logging (v3.1.0) to bridge Serilog with Microsoft.Extensions.Logging
  • Serilog.Sinks.File (v5.0.0) for file output

The FileLoggerFactory now configures Serilog with a file sink and uses SerilogLoggerFactory to provide ILogger instances. The log format and functionality remain the same from a user perspective.

Copilot AI changed the title Add diagnostic logging infrastructure using Microsoft.Extensions.Logging Add diagnostic logging infrastructure using Serilog Jan 5, 2026
@MichaelKoster70 MichaelKoster70 force-pushed the copilot/add-debug-logfile-feature branch from 45e5328 to bf164b1 Compare January 5, 2026 22:45
@MichaelKoster70 MichaelKoster70 force-pushed the copilot/add-debug-logfile-feature branch from 70504f9 to 801daca Compare January 6, 2026 07:04
@MichaelKoster70 MichaelKoster70 marked this pull request as ready for review January 6, 2026 19:54
@MichaelKoster70 MichaelKoster70 merged commit 44971c5 into main Jan 6, 2026
5 checks passed
@MichaelKoster70 MichaelKoster70 deleted the copilot/add-debug-logfile-feature branch January 6, 2026 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Debug Logfile

2 participants