Add support for MSBuild properties in the AppFolderPath #99
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds support for MSBuild property resolution in the AppFolderPath configuration, allowing dynamic path generation using properties like $(MSBuildProjectName). The default path has been updated from ~/project to ~/$(MSBuildProjectName) to provide more meaningful project-specific folder names.
Key Changes
- Introduced
IDebugTokenReplacerservice integration across the codebase to resolve MSBuild properties in folder paths - Updated
AdditionalDeploymentParserto handle both file and directory deployments with a newfileparameter - Refactored Linux shell command generation to use centralized format methods in
PackageConstants.LinuxShellCommands
Reviewed changes
Copilot reviewed 19 out of 19 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/Extension/RemoteDebuggerLauncher/Infrastructure/AdditionalDeploymentParser.cs | Refactored parser to distinguish between file and directory deployments, added handling for folder-target notation |
| src/Extension/RemoteDebuggerLauncher/PackageConstants.cs | Added LinuxShellCommands class for centralized command formatting, updated default AppFolderPath to use MSBuildProjectName |
| src/Extension/RemoteDebuggerLauncher/ProjectSystem/Build/SecureShellDeployService.cs | Integrated tokenReplacer for resolving MSBuild properties in AppFolderPath |
| src/Extension/RemoteDebuggerLauncher/ProjectSystem/Debugger/AdapterLaunchConfiguration.cs | Added tokenReplacer parameter and resolved AppFolderPath using token replacement |
| src/Extension/RemoteDebuggerLauncher/ProjectSystem/PackageServiceFactory.cs | Added tokenReplacer field and passed it to dependent services |
| src/Extension/RemoteDebuggerLauncher/RemoteOperations/SecureShellRemoteOperationsService.cs | Integrated tokenReplacer and migrated to centralized Linux shell commands |
| src/Extension/RemoteDebuggerLauncher/RemoteOperations/SecureShellRemoteBulkCopyDeltaSessionService.cs | Moved UploadFileAsync method and migrated to centralized command formatting |
| src/Extension/RemoteDebuggerLauncher/RemoteOperations/SecureShellRemoteBulkCopyRsyncSessionService.cs | Added directory creation and migrated to centralized command formatting |
| src/Tests/RemoteDebuggerLauncherUnitTests/AdditionalDeploymentParserUnitTests.cs | Updated all test method calls to include new file parameter, added tests for directory and folder-target scenarios |
| src/Extension/RemoteDebuggerLauncher/Infrastructure/UnixPath.cs | Added DenotesFolder method to check if path represents a folder |
| .github/workflows/project-ci.yml | Added copilot/** branch pattern to CI workflow triggers |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
src/Extension/RemoteDebuggerLauncher/Infrastructure/AdditionalDeploymentParser.cs
Outdated
Show resolved
Hide resolved
added 2 commits
January 5, 2026 17:06
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.