Skip to content

Refactor demoRead to format CSV output as a table #129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MichaelMcKibbin merged 3 commits into from
Dec 3, 2025
Merged

Refactor demoRead to format CSV output as a table #129

MichaelMcKibbin merged 3 commits into from
Dec 3, 2025

Conversation

@SunflowerRays
Copy link
Collaborator

@SunflowerRays SunflowerRays commented Dec 3, 2025

Refactor demoRead method to use CsvTableFormatter for displaying data as a table and handle row truncation.

SunflowerRays and others added 3 commits December 3, 2025 21:27
@SunflowerRays
Refactor demoRead to format CSV output as a table
f2283b6 
Refactor demoRead method to use CsvTableFormatter for displaying data as a table and handle row truncation.
@edsonesf
fix: Restore CsvTableFormatter.java that was accidentally deleted
b8fbfd4 
- CsvTableFormatter was deleted in this PR but Main.java depends on it
- Restored from main branch to fix compilation error
- All 452 tests now pass
@edsonesf
fix: Restore CsvTableFormatter.java that was accidentally deleted
00ae24d 
- CsvTableFormatter was deleted in this PR but Main.java depends on it
- Restored from main branch to fix compilation error
- All 452 tests now pass
@edsonesf
Copy link
Collaborator

edsonesf commented Dec 3, 2025

The refactored demoRead() method in Main.java to use CsvTableFormatter for displaying CSV data as formatted tables with borders instead of plain row output.
The method now creates aligned, bordered tables that are more readable, handles row truncation with a message showing how many rows were displayed versus total rows, and properly limits output when a maximum row count is specified.
Fixed a compilation error by restoring the accidentally deleted CsvTableFormatter.java file that the refactored code depends on.

SunflowerRays
SunflowerRays commented Dec 3, 2025
View reviewed changes
Copy link
Collaborator Author

@SunflowerRays SunflowerRays left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for restoring this

SunflowerRays
SunflowerRays commented Dec 3, 2025
View reviewed changes
Copy link
Collaborator Author

@SunflowerRays SunflowerRays left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for restoring this

@bogdansharp
Copy link
Collaborator

bogdansharp commented Dec 3, 2025

Excellent improvement — this greatly enhances the visual appearance of the demo.

@MichaelMcKibbin MichaelMcKibbin merged commit 5b808fb into main Dec 3, 2025
5 checks passed
@MichaelMcKibbin MichaelMcKibbin deleted the demomain5 branch December 3, 2025 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MichaelMcKibbin MichaelMcKibbin MichaelMcKibbin approved these changes

Assignees

@SunflowerRays SunflowerRays

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@SunflowerRays @edsonesf @bogdansharp @MichaelMcKibbin