Add support for FTDC MRPC command log collection #340

BenReed161 · 2025-03-06T19:46:58Z

command added: log dump using MRPC FTDC command to collect the FTDC from the switch and dump to binary file.

cli/main.c

lib/switchtec.c

cli/main.c

kelvin-cao · 2025-03-13T03:01:49Z

cli/main.c

+	} cfg = {
+		.type = SWITCHTEC_LOG_RAM,
+		.out_fd = 0,
+		.format = LOG_FMT_BIN


As we support parsing of the FTDC log, we should also support decoded TXT dump. Please refer to the 'log-dump' command, and see if adding FTDC there is appropriate.

Need to review existing FTDC log dump output headers and see if this can be adapted to what is currently present in the code

lsgunth

I had a couple very minor nits I had saw. Forgot to submit the review.

Other than that it looks good to me.

cli/main.c

kelvin-cao · 2025-03-20T17:07:32Z

lib/switchtec.c

 					     MRPC_FWLOGRD_FLASH,
 					     fd, log_def_file, info);
+	case SWITCHTEC_LOG_FTDC:
+		return switchtec_log_to_ftdc_file(dev, MRPC_FWLOGRD_RAM, fd);


Use log_d_to_file() would make more sense.

kelvin-cao · 2025-03-20T17:33:49Z

inc/switchtec/switchtec.h

 int switchtec_log_to_file(struct switchtec_dev *dev,
 		enum switchtec_log_type type, int fd, FILE *log_def_file,
 		struct switchtec_log_file_info *info);
+int switchtec_log_to_ftdc_file(struct switchtec_dev *dev,


It seems switchtec_log_to_file can do the same thing, is exposing this API necessary?

Adds new a new command option to call the FTDC MRPC collect the data and output to a binary file format. Uses existing log_dump command with -t to denote new FTDC log type.