Added minor fixes to memory management #343
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lsgunth
approved these changes
Apr 2, 2025
Collaborator
lsgunth
left a comment
lsgunth
left a comment
There was a problem hiding this comment.
Good catch on the missing free(). That's definitely worth while.
I'm not sure the point of reducing the version size at all. Saving a tiny amount of stack memory at the cost of a potential future overflow doesn't really seem worthwhile. At the very least these should have been in two separate patches.
kelvin-cao
approved these changes
Apr 22, 2025
BenReed161
force-pushed
the
minor-mem-fixes
branch
from
0efe21a to
3667aeb
Compare
changed the 64 byte buffer sent to switchtec_get_fw_version function to 32. Since we are expecting the version information to be at most 32 bytes there is no need to have the destination buffer set to 64 when strncpy is called in the switchtec_get_fw_version function within lib/platform/platform.c.
The summary pointer is not being freed after returning from the default case in the switch statement. Added a call to free the summary pointer before returning.
BenReed161
force-pushed
the
minor-mem-fixes
branch
from
3667aeb to
227d19a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First change in lib/fw.c relates to the summary pointer not being freed after returning from the default case in the switch statement Added a call to free the summary pointer before returning.
Second change in cli/main.c changed the 64 byte buffer sent to switchtec_get_fw_version function to 32. Since we are expecting the version information to be at most 32 bytes there is no need to have the destination buffer set to 64 when strncpy is called in the switchtec_get_fw_version function within lib/platform/platform.c.