Skip to content

Conversation

dongle-the-gadget
Copy link

No description provided.

@learn-build-service-prod
Copy link

Learn Build status updates of commit 9f7fb35:

💡 Validation status: suggestions

File Status Preview URL Details
docs/mvvm/generators/ObservableProperty.md 💡Suggestion View Details

docs/mvvm/generators/ObservableProperty.md

  • Line 17, Column 125: [Suggestion: learn-site-link-broken - See documentation] Link '/dotnet/api/communitytoolkit.mvvm.componentmodel.NotifyPropertyChangedForAttribute' points to a learn site page that doesn't exist. Check the path or URL and update the link.
  • Line 17, Column 239: [Suggestion: learn-site-link-broken - See documentation] Link '/dotnet/api/communitytoolkit.mvvm.componentmodel.NotifyCanExecuteChangedForAttribute' points to a learn site page that doesn't exist. Check the path or URL and update the link.
  • Line 17, Column 357: [Suggestion: learn-site-link-broken - See documentation] Link '/dotnet/api/communitytoolkit.mvvm.componentmodel.NotifyDataErrorInfoAttribute' points to a learn site page that doesn't exist. Check the path or URL and update the link.
  • Line 17, Column 461: [Suggestion: learn-site-link-broken - See documentation] Link '/dotnet/api/communitytoolkit.mvvm.componentmodel.NotifyPropertyChangedRecipientsAttribute' points to a learn site page that doesn't exist. Check the path or URL and update the link.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

@learn-build-service-prod
Copy link

Learn Build status updates of commit b52e493:

💡 Validation status: suggestions

File Status Preview URL Details
docs/mvvm/generators/ObservableProperty.md 💡Suggestion View Details

docs/mvvm/generators/ObservableProperty.md

  • Line 17, Column 125: [Suggestion: learn-site-link-broken - See documentation] Link '/dotnet/api/communitytoolkit.mvvm.componentmodel.NotifyPropertyChangedForAttribute' points to a learn site page that doesn't exist. Check the path or URL and update the link.
  • Line 17, Column 239: [Suggestion: learn-site-link-broken - See documentation] Link '/dotnet/api/communitytoolkit.mvvm.componentmodel.NotifyCanExecuteChangedForAttribute' points to a learn site page that doesn't exist. Check the path or URL and update the link.
  • Line 17, Column 357: [Suggestion: learn-site-link-broken - See documentation] Link '/dotnet/api/communitytoolkit.mvvm.componentmodel.NotifyDataErrorInfoAttribute' points to a learn site page that doesn't exist. Check the path or URL and update the link.
  • Line 17, Column 461: [Suggestion: learn-site-link-broken - See documentation] Link '/dotnet/api/communitytoolkit.mvvm.componentmodel.NotifyPropertyChangedRecipientsAttribute' points to a learn site page that doesn't exist. Check the path or URL and update the link.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

@learn-build-service-prod
Copy link

Learn Build status updates of commit 47cba21:

💡 Validation status: suggestions

File Status Preview URL Details
docs/mvvm/generators/ObservableProperty.md 💡Suggestion View Details

docs/mvvm/generators/ObservableProperty.md

  • Line 17, Column 125: [Suggestion: learn-site-link-broken - See documentation] Link '/dotnet/api/communitytoolkit.mvvm.componentmodel.NotifyPropertyChangedForAttribute' points to a learn site page that doesn't exist. Check the path or URL and update the link.
  • Line 17, Column 239: [Suggestion: learn-site-link-broken - See documentation] Link '/dotnet/api/communitytoolkit.mvvm.componentmodel.NotifyCanExecuteChangedForAttribute' points to a learn site page that doesn't exist. Check the path or URL and update the link.
  • Line 17, Column 357: [Suggestion: learn-site-link-broken - See documentation] Link '/dotnet/api/communitytoolkit.mvvm.componentmodel.NotifyDataErrorInfoAttribute' points to a learn site page that doesn't exist. Check the path or URL and update the link.
  • Line 17, Column 461: [Suggestion: learn-site-link-broken - See documentation] Link '/dotnet/api/communitytoolkit.mvvm.componentmodel.NotifyPropertyChangedRecipientsAttribute' points to a learn site page that doesn't exist. Check the path or URL and update the link.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

@jfversluis jfversluis requested a review from Sergio0694 June 6, 2025 14:07
@learn-build-service-prod
Copy link

Learn Build status updates of commit 5757a3d:

💡 Validation status: suggestions

File Status Preview URL Details
docs/mvvm/generators/ObservableProperty.md 💡Suggestion View Details

docs/mvvm/generators/ObservableProperty.md

  • Line 17, Column 125: [Suggestion: learn-site-link-broken - See documentation] Link '/dotnet/api/communitytoolkit.mvvm.componentmodel.NotifyPropertyChangedForAttribute' points to a learn site page that doesn't exist. Check the path or URL and update the link.
  • Line 17, Column 239: [Suggestion: learn-site-link-broken - See documentation] Link '/dotnet/api/communitytoolkit.mvvm.componentmodel.NotifyCanExecuteChangedForAttribute' points to a learn site page that doesn't exist. Check the path or URL and update the link.
  • Line 17, Column 357: [Suggestion: learn-site-link-broken - See documentation] Link '/dotnet/api/communitytoolkit.mvvm.componentmodel.NotifyDataErrorInfoAttribute' points to a learn site page that doesn't exist. Check the path or URL and update the link.
  • Line 17, Column 461: [Suggestion: learn-site-link-broken - See documentation] Link '/dotnet/api/communitytoolkit.mvvm.componentmodel.NotifyPropertyChangedRecipientsAttribute' points to a learn site page that doesn't exist. Check the path or URL and update the link.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

Copy link
Contributor

@Sergio0694 Sergio0694 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We shouldn't make the docs mention 'preview'. We can update them with .NET 10.

@dongle-the-gadget
Copy link
Author

I think that since we do have analyzers currently that discourage the field pattern, we should document the partial property pattern.

@michael-hawker
Copy link
Collaborator

We shouldn't make the docs mention 'preview'. We can update them with .NET 10.

Does it hurt to update them now and then again later? The analyzers do push folks this way now right, so could be good to have them aligned with the docs?

If we do that though, we should link to the docs about the preview setting for .NET in the .NET docs.

@michael-hawker michael-hawker added the dotnet The .NET Community Toolkit label Sep 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dotnet The .NET Community Toolkit

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants