-
Notifications
You must be signed in to change notification settings - Fork 119
Update observable property generator to use partial properties #554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Learn Build status updates of commit 9f7fb35: 💡 Validation status: suggestions
docs/mvvm/generators/ObservableProperty.md
For more details, please refer to the build report. Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them. |
Learn Build status updates of commit b52e493: 💡 Validation status: suggestions
docs/mvvm/generators/ObservableProperty.md
For more details, please refer to the build report. Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them. |
Learn Build status updates of commit 47cba21: 💡 Validation status: suggestions
docs/mvvm/generators/ObservableProperty.md
For more details, please refer to the build report. Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them. |
Learn Build status updates of commit 5757a3d: 💡 Validation status: suggestions
docs/mvvm/generators/ObservableProperty.md
For more details, please refer to the build report. Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We shouldn't make the docs mention 'preview'. We can update them with .NET 10.
I think that since we do have analyzers currently that discourage the field pattern, we should document the partial property pattern. |
Does it hurt to update them now and then again later? The analyzers do push folks this way now right, so could be good to have them aligned with the docs? If we do that though, we should link to the docs about the preview setting for .NET in the .NET docs. |
No description provided.