Skip to content

Conversation

Iridium-IO
Copy link

@Iridium-IO Iridium-IO commented Jul 6, 2025

  • Updated signature of generated Broadcast method sample code
  • Added sample code to [NotifyPropertyChangedRecipients] section

Updated signature of generated `Broadcast` method sample code
@learn-build-service-prod
Copy link

Learn Build status updates of commit 6a8f0aa:

💡 Validation status: suggestions

File Status Preview URL Details
docs/mvvm/generators/ObservableProperty.md 💡Suggestion View Details

docs/mvvm/generators/ObservableProperty.md

  • Line 17, Column 125: [Suggestion: learn-site-link-broken - See documentation] Link '/dotnet/api/communitytoolkit.mvvm.componentmodel.NotifyPropertyChangedForAttribute' points to a learn site page that doesn't exist. Check the path or URL and update the link.
  • Line 17, Column 239: [Suggestion: learn-site-link-broken - See documentation] Link '/dotnet/api/communitytoolkit.mvvm.componentmodel.NotifyCanExecuteChangedForAttribute' points to a learn site page that doesn't exist. Check the path or URL and update the link.
  • Line 17, Column 357: [Suggestion: learn-site-link-broken - See documentation] Link '/dotnet/api/communitytoolkit.mvvm.componentmodel.NotifyDataErrorInfoAttribute' points to a learn site page that doesn't exist. Check the path or URL and update the link.
  • Line 17, Column 461: [Suggestion: learn-site-link-broken - See documentation] Link '/dotnet/api/communitytoolkit.mvvm.componentmodel.NotifyPropertyChangedRecipientsAttribute' points to a learn site page that doesn't exist. Check the path or URL and update the link.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

Added example minimal <NotifyPropertyChangedRecipients> block
@learn-build-service-prod
Copy link

Learn Build status updates of commit 116c363:

💡 Validation status: suggestions

File Status Preview URL Details
docs/mvvm/generators/ObservableProperty.md 💡Suggestion View Details

docs/mvvm/generators/ObservableProperty.md

  • Line 17, Column 125: [Suggestion: learn-site-link-broken - See documentation] Link '/dotnet/api/communitytoolkit.mvvm.componentmodel.NotifyPropertyChangedForAttribute' points to a learn site page that doesn't exist. Check the path or URL and update the link.
  • Line 17, Column 239: [Suggestion: learn-site-link-broken - See documentation] Link '/dotnet/api/communitytoolkit.mvvm.componentmodel.NotifyCanExecuteChangedForAttribute' points to a learn site page that doesn't exist. Check the path or URL and update the link.
  • Line 17, Column 357: [Suggestion: learn-site-link-broken - See documentation] Link '/dotnet/api/communitytoolkit.mvvm.componentmodel.NotifyDataErrorInfoAttribute' points to a learn site page that doesn't exist. Check the path or URL and update the link.
  • Line 17, Column 461: [Suggestion: learn-site-link-broken - See documentation] Link '/dotnet/api/communitytoolkit.mvvm.componentmodel.NotifyPropertyChangedRecipientsAttribute' points to a learn site page that doesn't exist. Check the path or URL and update the link.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

@Iridium-IO
Copy link
Author

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

The irony of the instructions link not resolving anywhere.

@Iridium-IO Iridium-IO marked this pull request as ready for review July 6, 2025 08:05
@jfversluis
Copy link
Contributor

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

The irony of the instructions link not resolving anywhere.

It does, but its an internal link :)

@jfversluis jfversluis requested a review from Sergio0694 July 28, 2025 11:34
@michael-hawker michael-hawker added the dotnet The .NET Community Toolkit label Sep 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dotnet The .NET Community Toolkit

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants