-
Notifications
You must be signed in to change notification settings - Fork 119
Port Lottie concept docs from WCT 7x repo #596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Port Lottie concept docs from WCT 7x repo #596
Conversation
PoliCheck Scan ReportThe following report lists PoliCheck issues in PR files. Before you merge the PR, you must fix all severity-1 issues. Other issues are also a high priority. The AI Review Details column lists suggestions for either removing or replacing the terms. If you find a false positive result, mention it in a PR comment and include this text: #policheck-false-positive. This feedback helps reduce false positives in future scans. ✅ No issues foundMore information about PoliCheckInformation: PoliCheck | Severity Guidance | Term |
Learn Build status updates of commit 43069b1:
|
File | Status | Preview URL | Details |
---|---|---|---|
docs/windows/lottie-scenarios/async_play.md | View | Details | |
docs/windows/lottie-scenarios/getting_started_codegen.md | View | Details | |
docs/windows/lottie-scenarios/getting_started_json.md | View | Details | |
docs/windows/lottie-scenarios/json_codegen.md | View | Details | |
docs/windows/lottie-scenarios/playback.md | View | Details | |
docs/windows/lottie-scenarios/segments.md | View | Details | |
docs/windows/lottie-scenarios/fallback.md | ✅Succeeded | View |
docs/windows/lottie-scenarios/async_play.md
- Line 0, Column 0: [Warning: filename-invalid-character - See documentation]
Only lowercase letters, numbers, and hyphens are allowed in filenames.
- Line 14, Column 1: [Warning: file-not-found - See documentation]
Invalid file link: '../../resources/images/Animations/Lottie/LottieDocs_Async.gif'.
- Line 0, Column 0: [Suggestion: filename-incomplete - See documentation]
The filename contains an incomplete word, misspelled word, acronym, or abbreviation that is disallowed.
docs/windows/lottie-scenarios/getting_started_codegen.md
- Line 0, Column 0: [Warning: filename-invalid-character - See documentation]
Only lowercase letters, numbers, and hyphens are allowed in filenames.
- Line 60, Column 1: [Warning: file-not-found - See documentation]
Invalid file link: '../../resources/images/Animations/Lottie/LottieDocs_Autoplay.gif'.
- Line 0, Column 0: [Suggestion: filename-incomplete - See documentation]
The filename contains an incomplete word, misspelled word, acronym, or abbreviation that is disallowed.
docs/windows/lottie-scenarios/getting_started_json.md
- Line 0, Column 0: [Warning: filename-invalid-character - See documentation]
Only lowercase letters, numbers, and hyphens are allowed in filenames.
- Line 35, Column 15: [Warning: file-not-found - See documentation]
Invalid file link: '../../resources/images/Animations/Lottie/LottieDocs_BuildAction.png'.
- Line 51, Column 1: [Warning: file-not-found - See documentation]
Invalid file link: '../../resources/images/Animations/Lottie/LottieDocs_Autoplay.gif'.
- Line 0, Column 0: [Suggestion: filename-incomplete - See documentation]
The filename contains an incomplete word, misspelled word, acronym, or abbreviation that is disallowed.
docs/windows/lottie-scenarios/json_codegen.md
- Line 0, Column 0: [Warning: filename-invalid-character - See documentation]
Only lowercase letters, numbers, and hyphens are allowed in filenames.
- Line 12, Column 11: [Warning: file-not-found - See documentation]
Invalid file link: '../../resources/images/Animations/Lottie/LottieDocs_Workflow.png'.
- Line 0, Column 0: [Suggestion: filename-incomplete - See documentation]
The filename contains an incomplete word, misspelled word, acronym, or abbreviation that is disallowed.
docs/windows/lottie-scenarios/playback.md
- Line 45, Column 1: [Warning: file-not-found - See documentation]
Invalid file link: '../../resources/images/Animations/Lottie/LottieDocs_Playback.gif'.
docs/windows/lottie-scenarios/segments.md
- Line 85, Column 1: [Warning: file-not-found - See documentation]
Invalid file link: '../../resources/images/Animations/Lottie/LottieDocs_Segments.gif'.
For more details, please refer to the build report.
Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
- Add missing image assets to lottie-scenarios/assets/ folder - Copy 6 required images from 7x docs repo (LottieDocs_*.{gif,png}) - Update all image references from ../../resources/images/Animations/Lottie/ to ./assets/ - Resolves file-not-found linter warnings for PR MicrosoftDocs#596 This addresses the 'Missing image assets' action items from the Lottie PR linter warnings.
Learn Build status updates of commit 0c50419:
|
File | Status | Preview URL | Details |
---|---|---|---|
docs/windows/lottie-scenarios/assets/LottieDocs_Async.gif | View | Details | |
docs/windows/lottie-scenarios/assets/LottieDocs_Autoplay.gif | View | Details | |
docs/windows/lottie-scenarios/assets/LottieDocs_BuildAction.png | View | Details | |
docs/windows/lottie-scenarios/assets/LottieDocs_Playback.gif | View | Details | |
docs/windows/lottie-scenarios/assets/LottieDocs_Segments.gif | View | Details | |
docs/windows/lottie-scenarios/assets/LottieDocs_Workflow.png | View | Details | |
docs/windows/lottie-scenarios/getting-started-codegen.md | View | Details | |
docs/windows/lottie-scenarios/async-play.md | 💡Suggestion | View | Details |
docs/windows/lottie-scenarios/json-codegen.md | 💡Suggestion | View | Details |
docs/windows/lottie-scenarios/fallback.md | ✅Succeeded | View | |
docs/windows/lottie-scenarios/getting-started-json.md | ✅Succeeded | View | |
docs/windows/lottie-scenarios/playback.md | ✅Succeeded | View | |
docs/windows/lottie-scenarios/segments.md | ✅Succeeded | View |
docs/windows/lottie-scenarios/assets/LottieDocs_Async.gif
- Line 0, Column 0: [Warning: image-name-invalid-character - See documentation]
Only lowercase letters, numbers, and hyphens are allowed in image names.
- Line 0, Column 0: [Suggestion: image-name-incomplete - See documentation]
The image name contains an incomplete word, misspelled word, acronym, or abbreviation that is disallowed.
docs/windows/lottie-scenarios/assets/LottieDocs_Autoplay.gif
- Line 0, Column 0: [Warning: image-name-invalid-character - See documentation]
Only lowercase letters, numbers, and hyphens are allowed in image names.
- Line 0, Column 0: [Suggestion: image-name-incomplete - See documentation]
The image name contains an incomplete word, misspelled word, acronym, or abbreviation that is disallowed.
docs/windows/lottie-scenarios/assets/LottieDocs_BuildAction.png
- Line 0, Column 0: [Warning: image-name-invalid-character - See documentation]
Only lowercase letters, numbers, and hyphens are allowed in image names.
- Line 0, Column 0: [Suggestion: image-name-incomplete - See documentation]
The image name contains an incomplete word, misspelled word, acronym, or abbreviation that is disallowed.
docs/windows/lottie-scenarios/assets/LottieDocs_Playback.gif
- Line 0, Column 0: [Warning: image-name-invalid-character - See documentation]
Only lowercase letters, numbers, and hyphens are allowed in image names.
- Line 0, Column 0: [Suggestion: image-name-incomplete - See documentation]
The image name contains an incomplete word, misspelled word, acronym, or abbreviation that is disallowed.
docs/windows/lottie-scenarios/assets/LottieDocs_Segments.gif
- Line 0, Column 0: [Warning: image-name-invalid-character - See documentation]
Only lowercase letters, numbers, and hyphens are allowed in image names.
- Line 0, Column 0: [Suggestion: image-name-incomplete - See documentation]
The image name contains an incomplete word, misspelled word, acronym, or abbreviation that is disallowed.
docs/windows/lottie-scenarios/assets/LottieDocs_Workflow.png
- Line 0, Column 0: [Warning: image-name-invalid-character - See documentation]
Only lowercase letters, numbers, and hyphens are allowed in image names.
- Line 0, Column 0: [Suggestion: image-name-incomplete - See documentation]
The image name contains an incomplete word, misspelled word, acronym, or abbreviation that is disallowed.
docs/windows/lottie-scenarios/getting-started-codegen.md
- Line 10, Column 583: [Warning: file-not-found - See documentation]
Invalid file link: './json_codegen.md'.
- Line 68, Column 19: [Warning: file-not-found - See documentation]
Invalid file link: './json_codegen.md'.
- Line 0, Column 0: [Suggestion: filename-incomplete - See documentation]
The filename contains an incomplete word, misspelled word, acronym, or abbreviation that is disallowed.
docs/windows/lottie-scenarios/async-play.md
- Line 0, Column 0: [Suggestion: filename-incomplete - See documentation]
The filename contains an incomplete word, misspelled word, acronym, or abbreviation that is disallowed.
docs/windows/lottie-scenarios/json-codegen.md
- Line 0, Column 0: [Suggestion: filename-incomplete - See documentation]
The filename contains an incomplete word, misspelled word, acronym, or abbreviation that is disallowed.
For more details, please refer to the build report.
Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
PoliCheck Scan ReportThe following report lists PoliCheck issues in PR files. Before you merge the PR, you must fix all severity-1 issues. Other issues are also a high priority. The AI Review Details column lists suggestions for either removing or replacing the terms. If you find a false positive result, mention it in a PR comment and include this text: #policheck-false-positive. This feedback helps reduce false positives in future scans. ✅ No issues foundMore information about PoliCheckInformation: PoliCheck | Severity Guidance | Term |
- Update 2 references to use kebab-case filename - Resolves linter file-not-found warnings - Matches renamed file from previous commit
- Rename all LottieDocs_* images to lottiedocs-* equivalents - Update image references in markdown files accordingly - Resolves linter image-name-invalid-character warnings Image renames: - LottieDocs_Async.gif → lottiedocs-async.gif - LottieDocs_Autoplay.gif → lottiedocs-autoplay.gif - LottieDocs_BuildAction.png → lottiedocs-buildaction.png - LottieDocs_Playback.gif → lottiedocs-playback.gif - LottieDocs_Segments.gif → lottiedocs-segments.gif - LottieDocs_Workflow.png → lottiedocs-workflow.png
PoliCheck Scan ReportThe following report lists PoliCheck issues in PR files. Before you merge the PR, you must fix all severity-1 issues. Other issues are also a high priority. The AI Review Details column lists suggestions for either removing or replacing the terms. If you find a false positive result, mention it in a PR comment and include this text: #policheck-false-positive. This feedback helps reduce false positives in future scans. ✅ No issues foundMore information about PoliCheckInformation: PoliCheck | Severity Guidance | Term |
Learn Build status updates of commit 45272e8:
|
PoliCheck Scan ReportThe following report lists PoliCheck issues in PR files. Before you merge the PR, you must fix all severity-1 issues. Other issues are also a high priority. The AI Review Details column lists suggestions for either removing or replacing the terms. If you find a false positive result, mention it in a PR comment and include this text: #policheck-false-positive. This feedback helps reduce false positives in future scans. ✅ No issues foundMore information about PoliCheckInformation: PoliCheck | Severity Guidance | Term |
Learn Build status updates of commit d269890: 💡 Validation status: suggestionsdocs/windows/lottie-scenarios/assets/lottiedocs-async.gif
docs/windows/lottie-scenarios/assets/lottiedocs-autoplay.gif
docs/windows/lottie-scenarios/assets/lottiedocs-buildaction.png
docs/windows/lottie-scenarios/assets/lottiedocs-playback.gif
docs/windows/lottie-scenarios/assets/lottiedocs-segments.gif
docs/windows/lottie-scenarios/assets/lottiedocs-workflow.png
docs/windows/lottie-scenarios/async-play.md
docs/windows/lottie-scenarios/getting-started-codegen.md
docs/windows/lottie-scenarios/json-codegen.md
For more details, please refer to the build report. Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there not a lottie overview page? Wondering if we want this in its own docs/lottie
folder as well...
…per review feedback
PoliCheck Scan ReportThe following report lists PoliCheck issues in PR files. Before you merge the PR, you must fix all severity-1 issues. Other issues are also a high priority. The AI Review Details column lists suggestions for either removing or replacing the terms. If you find a false positive result, mention it in a PR comment and include this text: #policheck-false-positive. This feedback helps reduce false positives in future scans. ✅ No issues foundMore information about PoliCheckInformation: PoliCheck | Severity Guidance | Term |
Learn Build status updates of commit c906c01: 💡 Validation status: suggestions
docs/lottie/assets/lottiedocs-async.gif
docs/lottie/assets/lottiedocs-autoplay.gif
docs/lottie/assets/lottiedocs-buildaction.png
docs/lottie/assets/lottiedocs-playback.gif
docs/lottie/assets/lottiedocs-segments.gif
docs/lottie/assets/lottiedocs-workflow.png
docs/lottie/async-play.md
docs/lottie/getting-started-codegen.md
docs/lottie/json-codegen.md
For more details, please refer to the build report. Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them. |
This PR:
The WCT 7x docs repo at
MicrosoftDocs/WindowsCommunityToolkitDocs
contains docs for both the core Windows Community Toolkit and for the separately maintainedCommunityToolkit/Lottie-Windows
library.Porting of these documents to our live 8x-based concept docs repository is a required prerequisite before we can deprecate the WCT 7x docs repository.