Skip to content

Conversation

michaeltlombardi
Copy link
Contributor

PR Summary

Prior to this change, the authorization parameter handling didn't correctly handle an empty string for the authorized_accounts parameter. The casing for all other workflows used incorrect casing for workflow parameters, like Message_Body instead of message_body.

This change:

  • Corrects the casing of all parameter handler entries.
  • Ensures that the parameter handler for authorized_accounts only passes the parameter to the action script when the input value is a non-empty string.

PR Checklist

  • Descriptive Title: This PR's title is a synopsis of the changes it proposes.
  • Summary: This PR's summary describes the scope and intent of the change.
  • Contributor's Guide: I have read the contributor's guide.
  • Style: This PR adheres to the style guide.

Prior to this change, the authorization parameter handling didn't
correctly handle an empty string for the `authorized_accounts`
parameter. The casing for all other workflows used incorrect
casing for workflow parameters, like `Message_Body` instead of
`message_body`.

This change:

- Corrects the casing of all parameter handler entries.
- Ensures that the parameter handler for `authorized_accounts`
  only passes the parameter to the action script when the
  input value is a non-empty string.
Copy link
Collaborator

@sdwheeler sdwheeler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

Learn Build status updates of commit 8375f63:

✅ Validation status: passed

File Status Preview URL Details
.github/actions/commenting/expectations/v1/Parameters.psd1 ✅Succeeded
.github/actions/reporting/stale-content/v1/Parameters.psd1 ✅Succeeded
.github/actions/reporting/versioned-content/v1/Parameters.psd1 ✅Succeeded
.github/actions/verification/authorization/v1/Parameters.psd1 ✅Succeeded
.github/actions/verification/checklist/v1/Parameters.psd1 ✅Succeeded

For more details, please refer to the build report.

@sdwheeler sdwheeler merged commit 6065db0 into MicrosoftDocs:main Jul 31, 2025
3 of 4 checks passed
@michaeltlombardi michaeltlombardi deleted the gha/main/parameter-casing branch July 31, 2025 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants