Skip to content

Conversation

sharpchen
Copy link

PR Summary

You can't ignore parameter names, they're positional. This could be very misleading because it's using the wrong names in wrong order.

PR Checklist

  • Descriptive Title: This PR's title is a synopsis of the changes it proposes.
  • Summary: This PR's summary describes the scope and intent of the change.
  • Contributor's Guide: I have read the contributor's guide.
  • Style: This PR adheres to the style guide.

Copy link
Contributor

PoliCheck Scan Report

The following report lists PoliCheck issues in PR files. Before you merge the PR, you must fix all severity-1 issues. Other issues are also a high priority. The AI Review Details column lists suggestions for either removing or replacing the terms. If you find a false positive result, mention it in a PR comment and include this text: #policheck-false-positive. This feedback helps reduce false positives in future scans.

✅ No issues found

More information about PoliCheck

Information: PoliCheck | Severity Guidance | Term
For any questions: Try searching the learn.microsoft.com contributor guides or post your question in the Learn support channel.

Copy link

Expectations

Thanks for your submission! Here's a quick note to provide you with some context for what to expect from the docs team and the process now that you've submitted a PR. Even if you've contributed to this repo before, we strongly suggest reading this information; it might have changed since you last read it.

To see our process for reviewing PRs, please read our editor's checklist and process for managing pull requests in particular. Below is a brief, high-level summary of what to expect, but our contributor guide has expanded details.

The docs team begins to review your PR if you request them to or if your PR meets these conditions:

  • It is not a draft PR.
  • It does not have a WIP prefix in the title.
  • It passes validation and build steps.
  • It does not have any merge conflicts.
  • You have checked every box in the PR Checklist, indicating you have completed all required steps and marked your PR as Ready to Merge.

You can always request a review at any stage in your authoring process, the docs team is here to help! You do not need to submit a fully polished and finished draft; the docs team can help you get content ready for merge.

While reviewing your PR, the docs team may make suggestions, write comments, and ask questions. When all requirements are satisfied, the docs team marks your PR as Approved and merges it. Once your PR is merged, it is included the next time the documentation is published. For this project, the documentation is published daily at 3 p.m. Pacific Standard Time (PST).

Copy link
Contributor

Learn Build status updates of commit b57237f:

✅ Validation status: passed

File Status Preview URL Details
reference/7.5/Microsoft.PowerShell.Core/Register-ArgumentCompleter.md ✅Succeeded View (powershell-7.5)

For more details, please refer to the build report.

You can't ignore parameter names, they're positional. This could be very misleading because it's using the wrong names
Copy link
Contributor

PoliCheck Scan Report

The following report lists PoliCheck issues in PR files. Before you merge the PR, you must fix all severity-1 issues. Other issues are also a high priority. The AI Review Details column lists suggestions for either removing or replacing the terms. If you find a false positive result, mention it in a PR comment and include this text: #policheck-false-positive. This feedback helps reduce false positives in future scans.

✅ No issues found

More information about PoliCheck

Information: PoliCheck | Severity Guidance | Term
For any questions: Try searching the learn.microsoft.com contributor guides or post your question in the Learn support channel.

@sharpchen sharpchen closed this Sep 23, 2025
Copy link
Contributor

Learn Build status updates of commit b2dc7f9:

✅ Validation status: passed

File Status Preview URL Details
reference/7.5/Microsoft.PowerShell.Core/Register-ArgumentCompleter.md ✅Succeeded View (powershell-7.5)

For more details, please refer to the build report.

@sharpchen sharpchen deleted the patch-1 branch September 23, 2025 23:26
@sdwheeler
Copy link
Collaborator

That change isn't valid.

@sdwheeler sdwheeler added the do-not-merge Tag - closed without merging label Sep 24, 2025
@sharpchen
Copy link
Author

Yes I was awared of that, so I closed. Thanks for review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge Tag - closed without merging

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants