Skip to content

Conversation

jugi92
Copy link
Contributor

@jugi92 jugi92 commented Jun 5, 2025

No description provided.

Copy link
Contributor

@jugi92 : Thanks for your contribution! The author(s) and reviewer(s) have been notified to review your proposed change. @fbsolo-ms1

Copy link
Contributor

Learn Build status updates of commit e57cd99:

✅ Validation status: passed

File Status Preview URL Details
articles/machine-learning/how-to-access-data-interactive.md ✅Succeeded

For more details, please refer to the build report.

@v-regandowner
Copy link
Contributor

@samuel100 - Can you review the proposed changes?

IMPORTANT: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@prmerger-automator prmerger-automator bot added the aq-pr-triaged C+L Pull Request Review Team label label Jun 5, 2025
@v-dirichards
Copy link
Contributor

@samuel100 Could you review this proposed update to your article and enter #sign-off in a comment if it's ready to merge?

Thanks!

Copy link

github-actions bot commented Jul 1, 2025

This pull request has been inactive for at least 14 days. If you are finished with your changes, don't forget to sign off. See the contributor guide for instructions.
Get Help
Docs Support Teams Channel
Resolve Merge Conflict

@github-actions github-actions bot added the inactive This PR is inactive for more than 14 days label Jul 1, 2025
@v-dirichards
Copy link
Contributor

v-dirichards commented Jul 1, 2025

@s-polly

Can you review this old PR and determine whether it needs to be closed or merged?

IMPORTANT: When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge. If the changes no longer apply, add an explanation and a #please-close comment to close the PR.

@MicrosoftDocs/public-repo-pr-review-team

@v-dirichards
Copy link
Contributor

#assign: @s-polly

@github-actions github-actions bot removed the inactive This PR is inactive for more than 14 days label Jul 1, 2025
Copy link

This pull request has been inactive for at least 14 days. If you are finished with your changes, don't forget to sign off. See the contributor guide for instructions.
Get Help
Docs Support Teams Channel
Resolve Merge Conflict

@github-actions github-actions bot added the inactive This PR is inactive for more than 14 days label Jul 15, 2025
@v-dirichards
Copy link
Contributor

I sent an email to the content owner today.

@MicrosoftDocs/public-repo-pr-review-team

@github-actions github-actions bot removed the inactive This PR is inactive for more than 14 days label Jul 16, 2025
Copy link

This pull request has been inactive for at least 14 days. If you are finished with your changes, don't forget to sign off. See the contributor guide for instructions.
Get Help
Docs Support Teams Channel
Resolve Merge Conflict

@github-actions github-actions bot added the inactive This PR is inactive for more than 14 days label Jul 30, 2025
@ttorble
Copy link
Contributor

ttorble commented Aug 14, 2025

I sent a Teams message to the content owner today.

@MicrosoftDocs/public-repo-pr-review-team

@github-actions github-actions bot removed the inactive This PR is inactive for more than 14 days label Aug 14, 2025
@s-polly
Copy link
Contributor

s-polly commented Aug 14, 2025

#assign: @soumyapatro

@s-polly
Copy link
Contributor

s-polly commented Aug 14, 2025

@soumyapatro Please review these changes

Copy link
Contributor

The following users don't have valid GitHub IDs, or are not collaborators on this repo: soumyapatro

@v-dirichards
Copy link
Contributor

@soumyapatro

Can you review this old PR and determine whether it needs to be closed or merged?

@MicrosoftDocs/public-repo-pr-review-team

@v-dirichards
Copy link
Contributor

I sent an email to the content owner today.

@MicrosoftDocs/public-repo-pr-review-team

Copy link

github-actions bot commented Sep 9, 2025

This pull request has been inactive for at least 14 days. If you are finished with your changes, don't forget to sign off. See the contributor guide for instructions.
Get Help
Docs Support Teams Channel
Resolve Merge Conflict

@github-actions github-actions bot added the inactive This PR is inactive for more than 14 days label Sep 9, 2025
@v-dirichards
Copy link
Contributor

I sent a Teams message to the content owner today.

@MicrosoftDocs/public-repo-pr-review-team

@github-actions github-actions bot removed the inactive This PR is inactive for more than 14 days label Sep 10, 2025
Copy link

This pull request has been inactive for at least 14 days. If you are finished with your changes, don't forget to sign off. See the contributor guide for instructions.
Get Help
Docs Support Teams Channel
Resolve Merge Conflict

@github-actions github-actions bot added the inactive This PR is inactive for more than 14 days label Sep 24, 2025
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds documentation for using different authentication methods with the Azure Machine Learning FileSystem, specifically demonstrating how to use managed identity authentication through the ml_client parameter.

  • Adds a new section explaining how to use custom authentication with AzureMachineLearningFileSystem
  • Provides a code example showing managed identity credential usage with MLClient
  • Demonstrates passing the ml_client parameter to the filesystem for authentication

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

```

#### Use different authentication
The Filesystem Class accepts a parameter ml_client, which can be used to use the same auth as the one for the ml_client authentication, for example the user managed identity by providing the correct client_id.
Copy link
Preview

Copilot AI Sep 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The sentence has grammatical issues. Consider revising to: 'The Filesystem class accepts an ml_client parameter, which allows you to use the same authentication as the ml_client, for example user managed identity by providing the correct client_id.'

Suggested change
The Filesystem Class accepts a parameter ml_client, which can be used to use the same auth as the one for the ml_client authentication, for example the user managed identity by providing the correct client_id.
The Filesystem class accepts an ml_client parameter, which allows you to use the same authentication as the ml_client, for example user managed identity by providing the correct client_id.

Copilot uses AI. Check for mistakes.

Comment on lines +232 to +233
credential = ManagedIdentityCredential(client_id='<client_id>') # Replace with your client ID if needed

Copy link
Preview

Copilot AI Sep 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment suggests client_id is optional ('if needed'), but the code shows it as required in the placeholder. Consider clarifying when client_id is actually required versus optional for managed identity scenarios.

Suggested change
credential = ManagedIdentityCredential(client_id='<client_id>') # Replace with your client ID if needed
# For system-assigned managed identity, omit client_id:
credential = ManagedIdentityCredential()
# For user-assigned managed identity, provide your client_id:
# credential = ManagedIdentityCredential(client_id='<client_id>')

Copilot uses AI. Check for mistakes.

@v-dirichards
Copy link
Contributor

I sent an email to the content owner today.

@MicrosoftDocs/public-repo-pr-review-team

@github-actions github-actions bot removed the inactive This PR is inactive for more than 14 days label Sep 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants