-
Notifications
You must be signed in to change notification settings - Fork 359
Add fsspec auth option example #429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
@jugi92 : Thanks for your contribution! The author(s) and reviewer(s) have been notified to review your proposed change. @fbsolo-ms1 |
Learn Build status updates of commit e57cd99: ✅ Validation status: passed
For more details, please refer to the build report. |
@samuel100 - Can you review the proposed changes? IMPORTANT: When the changes are ready for publication, adding a #label:"aq-pr-triaged" |
@samuel100 Could you review this proposed update to your article and enter Thanks! |
This pull request has been inactive for at least 14 days. If you are finished with your changes, don't forget to sign off. See the contributor guide for instructions. |
Can you review this old PR and determine whether it needs to be closed or merged? IMPORTANT: When the changes are ready for publication, add a @MicrosoftDocs/public-repo-pr-review-team |
#assign: @s-polly |
This pull request has been inactive for at least 14 days. If you are finished with your changes, don't forget to sign off. See the contributor guide for instructions. |
I sent an email to the content owner today. @MicrosoftDocs/public-repo-pr-review-team |
This pull request has been inactive for at least 14 days. If you are finished with your changes, don't forget to sign off. See the contributor guide for instructions. |
I sent a Teams message to the content owner today. @MicrosoftDocs/public-repo-pr-review-team |
#assign: @soumyapatro |
@soumyapatro Please review these changes |
The following users don't have valid GitHub IDs, or are not collaborators on this repo: soumyapatro |
Can you review this old PR and determine whether it needs to be closed or merged? @MicrosoftDocs/public-repo-pr-review-team |
I sent an email to the content owner today. @MicrosoftDocs/public-repo-pr-review-team |
This pull request has been inactive for at least 14 days. If you are finished with your changes, don't forget to sign off. See the contributor guide for instructions. |
I sent a Teams message to the content owner today. @MicrosoftDocs/public-repo-pr-review-team |
This pull request has been inactive for at least 14 days. If you are finished with your changes, don't forget to sign off. See the contributor guide for instructions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds documentation for using different authentication methods with the Azure Machine Learning FileSystem, specifically demonstrating how to use managed identity authentication through the ml_client parameter.
- Adds a new section explaining how to use custom authentication with AzureMachineLearningFileSystem
- Provides a code example showing managed identity credential usage with MLClient
- Demonstrates passing the ml_client parameter to the filesystem for authentication
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
``` | ||
|
||
#### Use different authentication | ||
The Filesystem Class accepts a parameter ml_client, which can be used to use the same auth as the one for the ml_client authentication, for example the user managed identity by providing the correct client_id. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The sentence has grammatical issues. Consider revising to: 'The Filesystem class accepts an ml_client parameter, which allows you to use the same authentication as the ml_client, for example user managed identity by providing the correct client_id.'
The Filesystem Class accepts a parameter ml_client, which can be used to use the same auth as the one for the ml_client authentication, for example the user managed identity by providing the correct client_id. | |
The Filesystem class accepts an ml_client parameter, which allows you to use the same authentication as the ml_client, for example user managed identity by providing the correct client_id. |
Copilot uses AI. Check for mistakes.
credential = ManagedIdentityCredential(client_id='<client_id>') # Replace with your client ID if needed | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The comment suggests client_id is optional ('if needed'), but the code shows it as required in the placeholder. Consider clarifying when client_id is actually required versus optional for managed identity scenarios.
credential = ManagedIdentityCredential(client_id='<client_id>') # Replace with your client ID if needed | |
# For system-assigned managed identity, omit client_id: | |
credential = ManagedIdentityCredential() | |
# For user-assigned managed identity, provide your client_id: | |
# credential = ManagedIdentityCredential(client_id='<client_id>') |
Copilot uses AI. Check for mistakes.
I sent an email to the content owner today. @MicrosoftDocs/public-repo-pr-review-team |
No description provided.