-
Notifications
You must be signed in to change notification settings - Fork 328
Update keyless-connections.md #472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The correct audience for Azure Cognitive Search with RBAC is https://search.azure.com (not https://search.windows.net). Old SDKs or legacy code might use .windows.net, but for Azure AD/RBAC, it’s .azure.com.
@srishtigangulyabb : Thanks for your contribution! The author(s) and reviewer(s) have been notified to review your proposed change. |
Learn Build status updates of commit ac7675f: ✅ Validation status: passed
For more details, please refer to the build report. |
Can you review the proposed changes? Important: When the changes are ready for publication, adding a #label:"aq-pr-triaged" |
@HeidiSteen Could you review this proposed update to your article and enter Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need more information on why you are proposing this edit.
@@ -184,7 +184,7 @@ from azure.search.documents import SearchClient | |||
from azure.identity import DefaultAzureCredential, AzureAuthorityHosts | |||
|
|||
# Azure Public Cloud | |||
audience = "https://search.windows.net" | |||
audience = "[https://search.windows.net](https://search.azure.com)" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @srishtigangulyabb, I don't understand this edit. This value is the scope ("In the context of Microsoft Entra, scopes refer to the permissions or access levels granted to external identities"), and it's a string, not a URL.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@srishtigangulyabb Could you respond to the comment above?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The proposed change is from "https://search.windows.net" to "https://search.azure.com".
I have tried the code sample mentioned in the documentation but it gave me an error. When I learnt that the audience value should be "https://search.azure.com", I raised a request to update the documentation with the corrected value.
This pull request has been inactive for at least 14 days. If you are finished with your changes, don't forget to sign off. See the contributor guide for instructions. |
Can you respond to the author's question? ![]() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the contribution. I took a closer look, and you are correct about the valid value. We'll merge your update, and then I'll go back and add a few more examples.
#sign-off |
The correct audience for Azure Cognitive Search with RBAC is https://search.azure.com.
Old SDKs or legacy code might use .windows.net, but for Azure AD/RBAC, it’s .azure.com.