Skip to content

Conversation

sanjayananthamurthy
Copy link
Contributor

the acrpull wont work if container is configured for ABAC the identity should have the Container Registry Repository Contributor role

the acrpull wont work if container is configured for ABAC the identity should have the **Container Registry Repository Contributor** role
Copy link
Contributor

@sanjayananthamurthy : Thanks for your contribution! The author(s) and reviewer(s) have been notified to review your proposed change.

Copy link
Contributor

Learn Build status updates of commit 18d03ea:

💡 Validation status: suggestions

File Status Preview URL Details
articles/machine-learning/concept-endpoints-online-auth.md 💡Suggestion Details

articles/machine-learning/concept-endpoints-online-auth.md

  • Line 119, Column 53: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://learn.microsoft.com/azure/container-registry/container-registry-rbac-abac-repository-permissions?tabs=azure-portal' will be broken in isolated environments. Replace with a relative link.
  • Line 121, Column 3: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://learn.microsoft.com/azure/container-registry/media/container-registry-rbac-abac-repository-permissions/rbac-abac-repository-permissions-02-update-registry.png' will be broken in isolated environments. Replace with a relative link.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

@v-dirichards
Copy link
Contributor

@s-polly

Can you review the proposed changes?

Note: The new alt text needs to be updated to match Microsoft standards.

Important: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@prmerger-automator prmerger-automator bot added the aq-pr-triaged C+L Pull Request Review Team label label Aug 1, 2025
@sanjayananthamurthy
Copy link
Contributor Author

#sign-off

Copy link
Contributor

Invalid command: '#sign-off'. Only the assigned author of one or more file in this PR can sign off. @s-polly

Copy link
Contributor

Learn Build status updates of commit 40380d4:

✅ Validation status: passed

File Status Preview URL Details
articles/machine-learning/concept-endpoints-online-auth.md ✅Succeeded

For more details, please refer to the build report.

@v-regandowner
Copy link
Contributor

Hi @sanjayananthamurthy - In the public repo, pull requests should be signed off by the author, another member of the content team, or a PM.

@dem108 - Could you take a look? Thanks!

> [!IMPORTANT]
> If you configure your Container registry to use **[RBAC Registry + ABAC Repository Permissions](/azure/container-registry/container-registry-rbac-abac-repository-permissions?tabs=azure-portal)**
>
> ![Screenshot showing an ABAC permission on container.](/azure/container-registry/media/container-registry-rbac-abac-repository-permissions/rbac-abac-repository-permissions-02-update-registry.png)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This image doesn't exist. Please replace it with a valid one.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sanjayananthamurthy - The image is in a different repository, and it would need to be moved to azure-ai-docs if you want to use it here. However, since you're already referencing the article that includes the image, you might want to consider omitting it here.

Copy link
Contributor

Learn Build status updates of commit efb7e7f:

✅ Validation status: passed

File Status Preview URL Details
articles/machine-learning/concept-endpoints-online-auth.md ✅Succeeded

For more details, please refer to the build report.

Copy link

github-actions bot commented Sep 2, 2025

This pull request has been inactive for at least 14 days. If you are finished with your changes, don't forget to sign off. See the contributor guide for instructions.
Get Help
Docs Support Teams Channel
Resolve Merge Conflict

@github-actions github-actions bot added the inactive This PR is inactive for more than 14 days label Sep 2, 2025
@ShannonLeavitt ShannonLeavitt requested a review from Copilot October 7, 2025 20:40
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the documentation for Azure Machine Learning online endpoints authentication to clarify role requirements when using RBAC + ABAC (Attribute-Based Access Control) permissions with Azure Container Registry.

Key changes:

  • Added important notice about ABAC-enabled container registries
  • Clarified that traditional ACR roles (AcrPull, AcrPush, AcrDelete) are not honored in ABAC-enabled registries
  • Specified that Container Registry Repository Contributor role is required for endpoint identities

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment on lines +119 to +123
> If you configure your Container registry to use **[RBAC Registry + ABAC Repository Permissions](/azure/container-registry/container-registry-rbac-abac-repository-permissions?tabs=azure-portal)**
>
> ![Screenshot showing an ABAC permission on container.](/azure/container-registry/media/container-registry-rbac-abac-repository-permissions/rbac-abac-repository-permissions-02-update-registry.png)
>
>In this case, some existing role assignments aren't honored or will have different effects, because a different set of ACR built-in roles apply to ABAC-enabled registries.
Copy link
Preview

Copilot AI Oct 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The IMPORTANT callout block has an incomplete sentence structure. Line 119 starts with 'If you configure...' but doesn't have a complete conditional statement. Consider restructuring to either complete the conditional or change to a declarative statement like 'When you configure your Container registry to use..., the following considerations apply:'

Suggested change
> If you configure your Container registry to use **[RBAC Registry + ABAC Repository Permissions](/azure/container-registry/container-registry-rbac-abac-repository-permissions?tabs=azure-portal)**
>
> ![Screenshot showing an ABAC permission on container.](/azure/container-registry/media/container-registry-rbac-abac-repository-permissions/rbac-abac-repository-permissions-02-update-registry.png)
>
>In this case, some existing role assignments aren't honored or will have different effects, because a different set of ACR built-in roles apply to ABAC-enabled registries.
> When you configure your Container registry to use **[RBAC Registry + ABAC Repository Permissions](/azure/container-registry/container-registry-rbac-abac-repository-permissions?tabs=azure-portal)**, the following considerations apply:
>
> ![Screenshot showing an ABAC permission on container.](/azure/container-registry/media/container-registry-rbac-abac-repository-permissions/rbac-abac-repository-permissions-02-update-registry.png)
>
> In this case, some existing role assignments aren't honored or will have different effects, because a different set of ACR built-in roles apply to ABAC-enabled registries.

Copilot uses AI. Check for mistakes.

> For example, the **AcrPull**, **AcrPush**, and **AcrDelete** roles aren't honored in an ABAC-enabled registry.
> Instead, in ABAC-enabled registries, use the `Container Registry Repository Reader`, `Container Registry Repository Writer`, and `Container Registry Repository Contributor` roles to grant either registry-wide or repository-specific image permissions.
>
> Ensure that the SAI or the UAI of your endpoint has the **Container Registry Repository Contributor** role assigned on the Container registry.
Copy link
Preview

Copilot AI Oct 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] The role names should be consistently formatted. The three role names are enclosed in backticks while the role name in line 128 uses bold formatting. Consider using consistent formatting (either all backticks or all bold) for better readability.

Suggested change
> Ensure that the SAI or the UAI of your endpoint has the **Container Registry Repository Contributor** role assigned on the Container registry.
> Ensure that the SAI or the UAI of your endpoint has the `Container Registry Repository Contributor` role assigned on the Container registry.

Copilot uses AI. Check for mistakes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants