-
Notifications
You must be signed in to change notification settings - Fork 256
Add commands to check decryption progress in Linux data disk decryption steps warning #294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
In the Linux Encryption steps, we provide the commands to enable the encryption and then in the same section we provide the commands to monitor the encryption progress with PS cmdlet and with Azure CLI: 'https://learn.microsoft.com/en-us/azure/virtual-machines/linux/disk-encryption-linux?tabs=azcliazure%2Cenableadecli%2Cefacli%2Cadedatacli#enable-encryption-on-an-existing-or-running-linux-vm' However, we do not have that in the Linux decryption steps: 'https://learn.microsoft.com/en-us/azure/virtual-machines/linux/disk-encryption-linux?tabs=azcliazure%2Cenableadecli%2Cefacli%2Cadedatacli#disable-encryption' there is a warning that suggests that "Once decryption starts, it is advisable not to interfere with the process", but it would be useful to add a note in the warning mentioning that they can monitor the process and with a link to the commands used to check the decryption progress, something like this: 'To check the progress of decryption, use the Get-AzVMDiskEncryptionStatus PowerShell cmdlet or the vm encryption show CLI command, once the decryption process is completed, you can proceed to remove the encryption extension' I have had cases where customers get confused with the 'succeeded' output of the decryption command execution and proceed to remove the encryption extension when the data disks are still in progress to be decrypted.
@lopezesteban : Thanks for your contribution! The author(s) and reviewer(s) have been notified to review your proposed change. |
Learn Build status updates of commit 613b74d:
|
File | Status | Preview URL | Details |
---|---|---|---|
articles/virtual-machines/linux/disk-encryption-linux.md | Details |
articles/virtual-machines/linux/disk-encryption-linux.md
- Line 432, Column 191: [Warning: hard-coded-locale - See documentation]
Link 'https://learn.microsoft.com/en-us/cli/azure/vm/encryption?view=azure-cli-latest#az-vm-encryption-show' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
- Line 432, Column 48: [Suggestion: docs-link-absolute - See documentation]
Absolute link 'https://learn.microsoft.com/powershell/module/az.compute/get-azvmdiskencryptionstatus' will be broken in isolated environments. Replace with a relative link.
- Line 432, Column 191: [Suggestion: docs-link-absolute - See documentation]
Absolute link 'https://learn.microsoft.com/en-us/cli/azure/vm/encryption?view=azure-cli-latest#az-vm-encryption-show' will be broken in isolated environments. Replace with a relative link.
- Line 432, Column 191: [Suggestion: preserve-view-not-set - See documentation]
You've pinned this link to a specific version of content with the view parameter. It's recommended not to pin a version unless that version is A) not the default view and B) the context is about that version specifically. To proceed with pinning a version add the &preserve-view=true to the URL. Otherwise, remove the view parameter. URL: https://learn.microsoft.com/en-us/cli/azure/vm/encryption?view=azure-cli-latest#az-vm-encryption-show
For more details, please refer to the build report.
Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
@@ -428,6 +428,8 @@ You can disable encryption using Azure PowerShell, the Azure CLI, or with a Reso | |||
|
|||
> [!WARNING] | |||
> Once decryption starts, it is advisable not to interfere with the process. | |||
> | |||
> To check the progress of decryption, use the [Get-AzVMDiskEncryptionStatus](https://learn.microsoft.com/powershell/module/az.compute/get-azvmdiskencryptionstatus) PowerShell cmdlet or the [az vm encryption show](https://learn.microsoft.com/en-us/cli/azure/vm/encryption?view=azure-cli-latest#az-vm-encryption-show) CLI command, once the decryption process is completed, you can proceed to remove the encryption extension |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
> To check the progress of decryption, use the [Get-AzVMDiskEncryptionStatus](https://learn.microsoft.com/powershell/module/az.compute/get-azvmdiskencryptionstatus) PowerShell cmdlet or the [az vm encryption show](https://learn.microsoft.com/en-us/cli/azure/vm/encryption?view=azure-cli-latest#az-vm-encryption-show) CLI command, once the decryption process is completed, you can proceed to remove the encryption extension | |
> To check the progress of decryption, use the [Get-AzVMDiskEncryptionStatus](https://learn.microsoft.com/powershell/module/az.compute/get-azvmdiskencryptionstatus) PowerShell cmdlet or the [az vm encryption show](https://learn.microsoft.com/cli/azure/vm/encryption?view=azure-cli-latest#az-vm-encryption-show) CLI command, once the decryption process is completed, you can proceed to remove the encryption extension |
resolving build warning
Can you review the proposed changes? Important: When the changes are ready for publication, adding a #label:"aq-pr-triaged" |
@msmbaldwin Could you review this proposed update to your article and enter Thanks! |
This pull request has been inactive for at least 14 days. If you are finished with your changes, don't forget to sign off. See the contributor guide for instructions. |
In the Linux Encryption steps, we provide the commands to enable the encryption and then in the same section we provide the commands to monitor the encryption progress with PS cmdlet and with Azure CLI: Enable encryption on an existing or running Linux VM
However, we do not have that in the Linux decryption steps: Disable encryption
there is a warning that suggests that "Once decryption starts, it is advisable not to interfere with the process", but it would be useful to add a note in the warning mentioning that they can monitor the process and with a link to the commands used to check the decryption progress, something like this:
'To check the progress of decryption, use the Get-AzVMDiskEncryptionStatus PowerShell cmdlet or the vm encryption show CLI command, once the decryption process is completed, you can proceed to remove the encryption extension'
I have had cases where customers get confused with the 'succeeded' output of the decryption command execution and proceed to remove the encryption extension when the data disks are still in progress to be decrypted.