Skip to content

Commit 25f7c24

Browse files
committed
address PR comments
1 parent 6f6771d commit 25f7c24

File tree

1 file changed

+18
-26
lines changed

1 file changed

+18
-26
lines changed

articles/azure-arc/kubernetes/tutorial-arc-enabled-open-service-mesh.md

Lines changed: 18 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ OSM runs an Envoy-based control plane on Kubernetes, can be configured with [SMI
3939

4040
## Basic Installation of Azure Arc-enabled OSM on an Azure Arc-enabled Kubernetes Cluster
4141

42-
The following steps assume that you already have a cluster with supported a Kubernetes distribution connected to Azure Arc.
42+
The following steps assume that you already have a cluster with a supported Kubernetes distribution connected to Azure Arc.
4343
Ensure that your KUBECONFIG environment variable points to the kubeconfig of the Arc-enabled Kubernetes cluster.
4444

4545
Set the environment variables:
@@ -90,30 +90,8 @@ You should see output similar to the output shown below. It may take 3-5 minutes
9090
```
9191

9292
## Custom Installations of Azure Arc-enabled OSM
93-
The following sections describe certain custom installations of Azure Arc-enabled OSM.
94-
95-
### Setting values during OSM installation
96-
97-
Setting custom values of OSM requires creating a JSON file containing the required settings and passing them into `k8s-extension create` CLI command.
98-
For example, to change the log level of logs emitted by the OSM controller to `info`, the JSON file would be as follows:
99-
```json
100-
{
101-
"osm.osm.controllerLogLevel": "info"
102-
}
103-
```
104-
105-
Refer to sections below to determine the contents of the JSON file you require.
106-
107-
Then, set the file path as an environment variable:
108-
```azurecli-interactive
109-
export SETTINGS_FILE=<json-file-path>
110-
```
111-
112-
Finally, run the `az k8s-extension create` command to
113-
create the OSM extension, passing in the settings file using the `--configuration-settings` flag:
114-
```azurecli-interactive
115-
az k8s-extension create --cluster-name $CLUSTER_NAME --resource-group $RESOURCE_GROUP --cluster-type connectedClusters --extension-type Microsoft.openservicemesh --scope cluster --release-train pilot --name osm --version $VERSION --configuration-settings-file $SETTINGS_FILE
116-
```
93+
The following sections describe certain custom installations of Azure Arc-enabled OSM. Custom installations require setting
94+
values of OSM by in a JSON file and passing them into `k8s-extension create` CLI command as described below.
11795

11896
### Install OSM on an OpenShift cluster
11997

@@ -123,7 +101,6 @@ create the OSM extension, passing in the settings file using the `--configuratio
123101
"osm.osm.enablePrivilegedInitContainer": "true"
124102
}
125103
```
126-
127104

128105
2. [Install OSM with custom values](#setting-values-during-osm-installation).
129106

@@ -179,6 +156,21 @@ To set required values for configuring Contour during OSM installation, create t
179156

180157
[Now, install OSM with custom values](#setting-values-during-osm-installation).
181158

159+
### Setting values during OSM installation
160+
Values that need to be set during OSM installation need to be saved to a JSON file and passed in through the Azure CLI
161+
install command.
162+
163+
Once you have created a JSON file with applicable values as described above, set the file path as an environment variable:
164+
```azurecli-interactive
165+
export SETTINGS_FILE=<json-file-path>
166+
```
167+
168+
Run the `az k8s-extension create` command to create the OSM extension, passing in the settings file using the
169+
`--configuration-settings` flag:
170+
```azurecli-interactive
171+
az k8s-extension create --cluster-name $CLUSTER_NAME --resource-group $RESOURCE_GROUP --cluster-type connectedClusters --extension-type Microsoft.openservicemesh --scope cluster --release-train pilot --name osm --version $VERSION --configuration-settings-file $SETTINGS_FILE
172+
```
173+
182174
## Install Azure Arc-enabled OSM using ARM template
183175

184176
After connecting your cluster to Azure Arc, create a json file with the following format, making sure to update the \<cluster-name\> and \<osm-arc-version\> values:

0 commit comments

Comments
 (0)