Merge pull request #265768 from ShawnJackson/record-calls

[AQ] edit pass: record-calls

Author: ktoliver

articles/communication-services/how-tos/calling-sdk/includes/install-sdk/install-sdk-android.md

@@ -5,9 +5,11 @@ ms.topic: include
 ms.date: 09/08/2021
 ms.author: rifox
 ---
+
 ## Install the SDK
 
-Locate your project level build.gradle and make sure to add `mavenCentral()` to the list of repositories under `buildscript` and `allprojects`
+Locate your project-level *build.gradle* file and add `mavenCentral()` to the list of repositories under `buildscript` and `allprojects`:
+
 ```groovy
 buildscript {
     repositories {
@@ -27,7 +29,8 @@ allprojects {
     }
 }
 ```
-Then, in your module level build.gradle add the following lines to the dependencies section
+
+Then, in your module-level *build.gradle* file, add the following lines to the `dependencies` section:
 
 ```groovy
 dependencies {
@@ -39,27 +42,30 @@ dependencies {
 
 ### Initialize the required objects
 
-To create a `CallAgent` instance you have to call the `createCallAgent` method on a `CallClient` instance. This asynchronously returns a `CallAgent` instance object.
-The `createCallAgent` method takes a `CommunicationUserCredential` as an argument, which encapsulates an [access token](../../../../quickstarts/identity/access-tokens.md).
-To access the `DeviceManager`, a callAgent instance must be created first, and then you can use the `CallClient.getDeviceManager` method to get the DeviceManager.
+To create a `CallAgent` instance, you have to call the `createCallAgent` method on a `CallClient` instance. This call asynchronously returns a `CallAgent` instance object.
+
+The `createCallAgent` method takes `CommunicationUserCredential` as an argument, which encapsulates an [access token](../../../../quickstarts/identity/access-tokens.md).
+
+To access `DeviceManager`, you must create a `callAgent` instance first. Then you can use the `CallClient.getDeviceManager` method to get `DeviceManager`.
 
 ```java
 String userToken = '<user token>';
 CallClient callClient = new CallClient();
 CommunicationTokenCredential tokenCredential = new CommunicationTokenCredential(userToken);
-android.content.Context appContext = this.getApplicationContext(); // From within an Activity for instance
+android.content.Context appContext = this.getApplicationContext(); // From within an activity, for instance
 CallAgent callAgent = callClient.createCallAgent(appContext, tokenCredential).get();
 DeviceManager deviceManager = callClient.getDeviceManager(appContext).get();
 ```
+
 To set a display name for the caller, use this alternative method:
 
 ```java
 String userToken = '<user token>';
 CallClient callClient = new CallClient();
 CommunicationTokenCredential tokenCredential = new CommunicationTokenCredential(userToken);
-android.content.Context appContext = this.getApplicationContext(); // From within an Activity for instance
+android.content.Context appContext = this.getApplicationContext(); // From within an activity, for instance
 CallAgentOptions callAgentOptions = new CallAgentOptions();
 callAgentOptions.setDisplayName("Alice Bob");
 DeviceManager deviceManager = callClient.getDeviceManager(appContext).get();
 CallAgent callAgent = callClient.createCallAgent(appContext, tokenCredential, callAgentOptions).get();
-```
+```

articles/communication-services/how-tos/calling-sdk/includes/install-sdk/install-sdk-ios.md

@@ -5,19 +5,20 @@ ms.topic: include
 ms.date: 09/08/2021
 ms.author: rifox
 ---
+
 ## Set up your system
 
 ### Create the Xcode project
 
-In Xcode, create a new iOS project and select the **Single View App** template. This quickstart uses the [SwiftUI framework](https://developer.apple.com/xcode/swiftui/), so you should set the **Language** to **Swift** and **User Interface** to **SwiftUI**. 
+In Xcode, create a new iOS project and select the **Single View App** template. This quickstart uses the [SwiftUI framework](https://developer.apple.com/xcode/swiftui/), so you should set **Language** to **Swift** and set **Interface** to **SwiftUI**.
 
-You're not going to create unit tests or UI tests during this quickstart. Feel free to clear the **Include Unit Tests** and **Include UI Tests** text boxes.
+You're not going to create tests during this quickstart. Feel free to clear the **Include Tests** checkbox.
 
 :::image type="content" source="../../../../quickstarts/voice-video-calling/media/ios/xcode-new-ios-project.png" alt-text="Screenshot that shows the window for creating a project within Xcode.":::
 
-### Install the package and dependencies with CocoaPods
+### Install the package and dependencies by using CocoaPods
 
-1. Create a Podfile for your application, like this:
+1. Create a Podfile for your application, like this example:
 
     ```
     platform :ios, '13.0'
@@ -27,13 +28,13 @@ You're not going to create unit tests or UI tests during this quickstart. Feel f
     end
     ```
 2. Run `pod install`.
-3. Open `.xcworkspace` with Xcode.
+3. Open `.xcworkspace` by using Xcode.
 
 ### Request access to the microphone
 
-To access the device's microphone, you need to update your app's information property list with `NSMicrophoneUsageDescription`. You set the associated value to a `string` that will be included in the dialog that the system uses to request access from the user.
+To access the device's microphone, you need to update your app's information property list by using `NSMicrophoneUsageDescription`. You set the associated value to a string that will be included in the dialog that the system uses to request access from the user.
 
-Right-click the `Info.plist` entry of the project tree and select **Open As** > **Source Code**. Add the following lines in the top-level `<dict>` section, and then save the file.
+Right-click the *Info.plist* entry of the project tree, and then select **Open As** > **Source Code**. Add the following lines in the top-level `<dict>` section, and then save the file.
 
 ```xml
 <key>NSMicrophoneUsageDescription</key>
@@ -42,7 +43,7 @@ Right-click the `Info.plist` entry of the project tree and select **Open As** >
 
 ### Set up the app framework
 
-Open your project's *ContentView.swift* file and add an `import` declaration to the top of the file to import the `AzureCommunicationCalling` library. In addition, import `AVFoundation`. You'll need it for audio permission requests in the code.
+Open your project's *ContentView.swift* file. Add an `import` declaration to the top of the file to import the `AzureCommunicationCalling` library. In addition, import `AVFoundation`. You'll need it for audio permission requests in the code.
 
 ```swift
 import AzureCommunicationCalling
@@ -53,7 +54,7 @@ import AVFoundation
 
 To create a `CallAgent` instance from `CallClient`, you have to use a `callClient.createCallAgent` method that asynchronously returns a `CallAgent` object after it's initialized.
 
-To create a call client, you have to pass a `CommunicationTokenCredential` object.
+To create a call client, pass a `CommunicationTokenCredential` object:
 
 ```swift
 import AzureCommunication
@@ -76,7 +77,7 @@ public func fetchTokenSync(then onCompletion: TokenRefreshOnCompletion) {
 }
 ```
 
-Pass the `CommunicationTokenCredential` object that you created to `CallClient`, and set the display name.
+Pass the `CommunicationTokenCredential` object that you created to `CallClient`, and set the display name:
 
 ```swift
 self.callClient = CallClient()
@@ -92,4 +93,4 @@ self.callClient!.createCallAgent(userCredential: userCredential!,
             print("Create agent failed")
         }
 })
-```
+```

articles/communication-services/how-tos/calling-sdk/includes/install-sdk/install-sdk-web.md

@@ -7,7 +7,7 @@ ms.author: rifox
 ---
 ## Install the SDK
 
-Use the `npm install` command to install the Azure Communication Services calling and common SDKs for JavaScript.
+Use the `npm install` command to install the Azure Communication Services Common and Calling SDKs for JavaScript:
 
 ```console
 npm install @azure/communication-common --save
@@ -16,7 +16,7 @@ npm install @azure/communication-calling --save
 
 ## Initialize required objects
 
-A CallClient, instance is required for most call operations. Let's create a new `CallClient` instance. You can configure it with custom options like a Logger instance.
+A `CallClient` instance is required for most call operations. Here, you create a new `CallClient` instance. You can configure it with custom options like a `Logger` instance.
 
 When you have a `CallClient` instance, you can create a `CallAgent` instance by calling the `createCallAgent` method on the `CallClient` instance. This method asynchronously returns a `CallAgent` instance object.
 
@@ -32,7 +32,7 @@ const { AzureLogger, setLogLevel } = require("@azure/logger");
 // Set the logger's log level
 setLogLevel('verbose');
 
-// Redirect log output to wherever desired. To console, file, buffer, REST API, etc...
+// Redirect log output to console, file, buffer, REST API, or whatever location you want
 AzureLogger.log = (...args) => {
     console.log(...args); // Redirect log output to console
 };
@@ -42,4 +42,4 @@ callClient = new CallClient(options);
 const tokenCredential = new AzureCommunicationTokenCredential(userToken);
 const callAgent = await callClient.createCallAgent(tokenCredential, {displayName: 'optional Azure Communication Services user name'});
 const deviceManager = await callClient.getDeviceManager()
-```
+```

articles/communication-services/how-tos/calling-sdk/includes/install-sdk/install-sdk-windows.md

@@ -5,21 +5,23 @@ ms.topic: include
 ms.date: 05/30/2023
 ms.author: jowang
 ---
-## Setting up
+## Set up your system
 
-### Creating the Visual Studio project
+### Create the Visual Studio project
 
-For UWP app, in Visual Studio 2022, create a new `Blank App (Universal Windows)` project. After entering the project name, feel free to pick any Windows SDK greater than `10.0.17763.0`.
+For a UWP app, in Visual Studio 2022, create a new **Blank App (Universal Windows)** project. After you enter the project name, feel free to choose any Windows SDK later than 10.0.17763.0.
 
-For WinUI 3 app, create a new project with the `Blank App, Packaged (WinUI 3 in Desktop)` template to set up a single-page WinUI 3 app. [Windows App SDK version 1.3](/windows/apps/windows-app-sdk/stable-channel#version-13) and above is required.
-### Install the package and dependencies with NuGet Package Manager
+For a WinUI 3 app, create a new project with the **Blank App, Packaged (WinUI 3 in Desktop)** template to set up a single-page WinUI 3 app. [Windows App SDK version 1.3](/windows/apps/windows-app-sdk/stable-channel#version-13) or later is required.
+
+### Install the package and dependencies by using NuGet Package Manager
 
 The Calling SDK APIs and libraries are publicly available via a NuGet package.
-The following steps exemplify how to find, download, and install the Calling SDK NuGet package.
 
-1. Open NuGet Package Manager (`Tools` -> `NuGet Package Manager` -> `Manage NuGet Packages for Solution`)
-2. Click on `Browse` and then type `Azure.Communication.Calling.WindowsClient` in the search box.
-3. Make sure that `Include prerelease` check box is selected.
-4. Click on the `Azure.Communication.Calling.WindowsClient` package, select `Azure.Communication.Calling.WindowsClient` [1.4.0-beta.1](https://www.nuget.org/packages/Azure.Communication.Calling.WindowsClient/1.4.0-beta.1) or newer version.
-5. Select the checkbox corresponding to the CS project on the right-side tab.
-6. Click on the `Install` button.
+The following steps exemplify how to find, download, and install the Calling SDK NuGet package:
+
+1. Open NuGet Package Manager by selecting **Tools** > **NuGet Package Manager** > **Manage NuGet Packages for Solution**.
+2. Select **Browse**, and then enter `Azure.Communication.Calling.WindowsClient` in the search box.
+3. Make sure that the **Include prerelease** check box is selected.
+4. Select the `Azure.Communication.Calling.WindowsClient` package, and then select `Azure.Communication.Calling.WindowsClient` [1.4.0-beta.1](https://www.nuget.org/packages/Azure.Communication.Calling.WindowsClient/1.4.0-beta.1) or a newer version.
+5. Select the checkbox that corresponds to the Communication Services project on the right-side tab.
+6. Select the **Install** button.

articles/communication-services/how-tos/calling-sdk/includes/record-calls/record-calls-android.md

@@ -8,13 +8,16 @@ ms.author: rifox
 [!INCLUDE [Install SDK](../install-sdk/install-sdk-android.md)]
 
 ## Record calls
-> [!WARNING]
-> Up until version 1.1.0 and beta release version 1.1.0-beta.1 of the Azure Communication Services Calling Android SDK has the `isRecordingActive` and `addOnIsRecordingActiveChangedListener` are part of the `Call` object. For new beta releases, those APIs have been moved as an extended feature of `Call` just like described below.
 
 > [!NOTE]
-> This API is provided as a preview for developers and may change based on feedback that we receive. Do not use this API in a production environment. To use this api please use 'beta' release of Azure Communication Services Calling Android SDK
+> This API is provided as a preview for developers and might change based on feedback that we receive. Don't use this API in a production environment. To use this API, use the beta release of the Azure Communication Services Calling Android SDK.
+
+Call recording is an extended feature of the core `Call` object.
+
+> [!WARNING]
+> Up until version 1.1.0 and beta release version 1.1.0-beta.1 of the Azure Communication Services Calling Android SDK, `isRecordingActive` and `addOnIsRecordingActiveChangedListener` were part of the `Call` object. For new beta releases, those APIs were moved as an extended feature of `Call`.
 
-Call recording is an extended feature of the core `Call` object. You first need to obtain the recording feature object:
+You first need to obtain the recording feature object:
 
 ```java
 RecordingCallFeature callRecordingFeature = call.feature(Features.RECORDING);
@@ -30,15 +33,15 @@ You can also subscribe to recording changes:
 
 ```java
 private void handleCallOnIsRecordingChanged(PropertyChangedEvent args) {
-	boolean isRecordingActive = callRecordingFeature.isRecordingActive();
+  boolean isRecordingActive = callRecordingFeature.isRecordingActive();
 }
 
 callRecordingFeature.addOnIsRecordingActiveChangedListener(handleCallOnIsRecordingChanged);
 ```
 
-If you want to start recording from your application, please first follow [Calling Recording overview](../../../../concepts/voice-video-calling/call-recording.md) for the steps to set up call recording.
+If you want to start recording from your application, first follow [Call recording overview](../../../../concepts/voice-video-calling/call-recording.md) for the steps to set up call recording.
 
-Once you have the call recording setup on your server, from your Android application you need to obtain the `ServerCallId` value from the call and then send it to your server to start the recording process. The `ServerCallId` value can be found using `getServerCallId()` from the `CallInfo` class, which can be found in the class object using `getInfo()`.
+After you set up call recording on your server, from your Android application, you need to obtain the `ServerCallId` value from the call and then send it to your server to start the recording process. You can find the `ServerCallId` value by using `getServerCallId()` from the `CallInfo` class. You can find the `CallInfo` class in the class object by using `getInfo()`.
 
 ```java
 try {
@@ -51,9 +54,9 @@ try {
 }
 ```
 
-When recording is started from the server, the event `handleCallOnIsRecordingChanged` will trigger and the value of `callRecordingFeature.isRecordingActive()` will be `true`.
+When you start recording from the server, the event `handleCallOnIsRecordingChanged` is triggered and the value of `callRecordingFeature.isRecordingActive()` is `true`.
 
-Just like starting the call recording, if you want to stop the call recording you need to get the `ServerCallId` and send it to your recording server so that it can stop the call recording.
+Just like starting the call recording, if you want to stop the call recording, you need to get `ServerCallId` and send it to your recording server so that it can stop the recording:
 
 ```java
 try {
@@ -66,4 +69,4 @@ try {
 }
 ```
 
-When recording is stopped from the server, the event `handleCallOnIsRecordingChanged` will trigger and the value of `callRecordingFeature.isRecordingActive()` will be `false`.
+When you stop recording from the server, the event `handleCallOnIsRecordingChanged` is triggered and the value of `callRecordingFeature.isRecordingActive()` is `false`.