-
Notifications
You must be signed in to change notification settings - Fork 21.8k
Update add-api.md #127663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Update add-api.md #127663
Conversation
build steps for React[Vite] added to point to dist folder
@rvrama : Thanks for your contribution! The author(s) and reviewer(s) have been notified to review your proposed change. |
Learn Build status updates of commit 5caaab0:
|
File | Status | Preview URL | Details |
---|---|---|---|
articles/static-web-apps/add-api.md | Details |
articles/static-web-apps/add-api.md
- Line 260, Column 1: [Warning: invalid-tab-group - See documentation]
Tab group with different tab id set.
For more details, please refer to the build report.
Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
Missed to address the Vite related changes in other places
Learn Build status updates of commit b87a56e:
|
File | Status | Preview URL | Details |
---|---|---|---|
articles/static-web-apps/add-api.md | Details |
articles/static-web-apps/add-api.md
- Line 260, Column 1: [Warning: invalid-tab-group - See documentation]
Tab group with different tab id set.
- Line 308, Column 5: [Warning: invalid-tab-group - See documentation]
Tab group with different tab id set.
For more details, please refer to the build report.
Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
@rvrama Thank you for your contribution. Would you take a moment to sign the Contributor License Agreement (CLA)? After the CLA is signed, someone can review your pull request. Thanks! |
@microsoft-github-policy-service agree |
@microsoft-github-policy-service agree |
Learn Build status updates of commit b87a56e:
|
File | Status | Preview URL | Details |
---|---|---|---|
articles/static-web-apps/add-api.md | Details |
articles/static-web-apps/add-api.md
- Line 260, Column 1: [Warning: invalid-tab-group - See documentation]
Tab group with different tab id set.
- Line 308, Column 5: [Warning: invalid-tab-group - See documentation]
Tab group with different tab id set.
For more details, please refer to the build report.
Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds documentation for building and running React applications using Vite within the Static Web Apps guide. The update provides specific build instructions that reference the dist
output folder used by Vite.
- Adds React (Vite) tab section with build commands using
npm run dist
- Includes SWA CLI start command pointing to the correct
dist
output folder
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
||
```bash | ||
npm install | ||
npm run dist |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The build command npm run dist
is incorrect for React with Vite. The standard Vite build command is npm run build
, which outputs to the dist
folder by default.
npm run dist | |
npm run build |
Copilot uses AI. Check for mistakes.
Can you review the proposed changes? Note: these warnings will need to be resolved before we can merge. If you approve the new content in this PR, the commits must be moved to the private repository for automated checks and publishing. After you move the commits, close this PR ( Important: When the changes are ready for publication, adding a #label:"aq-pr-triaged" |
build steps for React[Vite] added to point to dist folder