Skip to content

Conversation

rvrama
Copy link

@rvrama rvrama commented Sep 28, 2025

build steps for React[Vite] added to point to dist folder

build steps for React[Vite] added to point to dist folder
Copy link
Contributor

@rvrama : Thanks for your contribution! The author(s) and reviewer(s) have been notified to review your proposed change.

Copy link
Contributor

Learn Build status updates of commit 5caaab0:

⚠️ Validation status: warnings

File Status Preview URL Details
articles/static-web-apps/add-api.md ⚠️Warning Details

articles/static-web-apps/add-api.md

  • Line 260, Column 1: [Warning: invalid-tab-group - See documentation] Tab group with different tab id set.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

Missed to address the Vite related changes in other places
Copy link
Contributor

Learn Build status updates of commit b87a56e:

⚠️ Validation status: warnings

File Status Preview URL Details
articles/static-web-apps/add-api.md ⚠️Warning Details

articles/static-web-apps/add-api.md

  • Line 260, Column 1: [Warning: invalid-tab-group - See documentation] Tab group with different tab id set.
  • Line 308, Column 5: [Warning: invalid-tab-group - See documentation] Tab group with different tab id set.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

@ttorble
Copy link
Contributor

ttorble commented Sep 29, 2025

@rvrama Thank you for your contribution. Would you take a moment to sign the Contributor License Agreement (CLA)? After the CLA is signed, someone can review your pull request. Thanks!

@ttorble ttorble added the aq-pr-triaged tracking label for the PR review team label Sep 29, 2025
@rvrama
Copy link
Author

rvrama commented Sep 29, 2025

@microsoft-github-policy-service agree

@microsoft-github-policy-service agree

@rvrama rvrama closed this Sep 29, 2025
@rvrama rvrama reopened this Sep 29, 2025
@rvrama
Copy link
Author

rvrama commented Sep 29, 2025

@microsoft-github-policy-service agree

Copy link
Contributor

Learn Build status updates of commit b87a56e:

⚠️ Validation status: warnings

File Status Preview URL Details
articles/static-web-apps/add-api.md ⚠️Warning Details

articles/static-web-apps/add-api.md

  • Line 260, Column 1: [Warning: invalid-tab-group - See documentation] Tab group with different tab id set.
  • Line 308, Column 5: [Warning: invalid-tab-group - See documentation] Tab group with different tab id set.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds documentation for building and running React applications using Vite within the Static Web Apps guide. The update provides specific build instructions that reference the dist output folder used by Vite.

  • Adds React (Vite) tab section with build commands using npm run dist
  • Includes SWA CLI start command pointing to the correct dist output folder

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.


```bash
npm install
npm run dist
Copy link
Preview

Copilot AI Sep 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The build command npm run dist is incorrect for React with Vite. The standard Vite build command is npm run build, which outputs to the dist folder by default.

Suggested change
npm run dist
npm run build

Copilot uses AI. Check for mistakes.

@v-dirichards
Copy link
Contributor

@v1212

Can you review the proposed changes?

Note: these warnings will need to be resolved before we can merge.

If you approve the new content in this PR, the commits must be moved to the private repository for automated checks and publishing. After you move the commits, close this PR (#please-close). If you need help moving the commits, contact the publicprs alias.

Important: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants