-
Notifications
You must be signed in to change notification settings - Fork 21.8k
Updated add-api.md to suit React Vite users as well #127664
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Made changes in 2 places for React Vite users to use dist folder instead of build. While building and while running with swa command locally.
@rvrama : Thanks for your contribution! The author(s) and reviewer(s) have been notified to review your proposed change. |
Learn Build status updates of commit b1e877a:
|
File | Status | Preview URL | Details |
---|---|---|---|
articles/static-web-apps/add-api.md | Details |
articles/static-web-apps/add-api.md
- Line 260, Column 1: [Warning: invalid-tab-group - See documentation]
Tab group with different tab id set.
- Line 307, Column 5: [Warning: invalid-tab-group - See documentation]
Tab group with different tab id set.
For more details, please refer to the build report.
Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Updates the documentation for adding APIs to Static Web Apps to include specific instructions for React Vite users, who use the dist
folder instead of the build
folder for their build output.
- Adds a new tab section for React (Vite) with proper build command and folder references
- Updates both the build instructions and local development commands to accommodate Vite's
dist
output folder
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
||
```bash | ||
npm install | ||
npm run dist |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The build command npm run dist
is incorrect for React Vite projects. The standard Vite build command is npm run build
, which outputs to the dist
folder by default.
npm run dist | |
npm run build |
Copilot uses AI. Check for mistakes.
Can you review the proposed changes? IMPORTANT: When the changes are ready for publication, adding a #label:"aq-pr-triaged" |
Made changes in 2 places for React Vite users to use dist folder instead of build. While building and while running with swa command locally. PLEASE IGNORE MY PREVIOUS COMMIT as this has complete change.