add more options in json file and explain filters#128285
add more options in json file and explain filters#128285ybtDimo wants to merge 1 commit intoMicrosoftDocs:mainfrom
Conversation
|
@microsoft-github-policy-service agree |
|
@ybtDimo : Thanks for your contribution! The author(s) and reviewer(s) have been notified to review your proposed change. |
|
Learn Build status updates of commit adeabc6: ✅ Validation status: passed
For more details, please refer to the build report. |
There was a problem hiding this comment.
Pull request overview
Updates the object replication policy documentation to include additional JSON options and explain how to configure rule filters.
Changes:
- Added
metricsandpriorityReplicationfields to the sample policy JSON. - Introduced a new section describing filter customization with JSON examples.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "metrics": { | ||
| "enabled": false | ||
| }, | ||
| "priorityReplication": "false", |
There was a problem hiding this comment.
In JSON, booleans must not be quoted. Using "false" makes this a string value, which is very likely to be rejected by the ARM/API schema expecting a boolean. Change it to: "priorityReplication": false.
| "priorityReplication": "false", | |
| "priorityReplication": false, |
| "sourceAccount": "/subscriptions/<subscriptionId>/resourceGroups/<resource-group>/providers/Microsoft.Storage/storageAccounts/<storage-account>", | ||
| "destinationAccount": "/subscriptions/<subscriptionId>/resourceGroups/<resource-group>/providers/Microsoft.Storage/storageAccounts/<storage-account>", | ||
| "metrics": { | ||
| "enabled": false |
There was a problem hiding this comment.
The indentation on the enabled line uses a tab/misaligned whitespace compared to the rest of the JSON sample. Please normalize the indentation (spaces) so the sample is consistently formatted and easier to copy/paste.
| "enabled": false | |
| "enabled": false |
| } | ||
| } | ||
| ``` | ||
| #### Customs filters |
There was a problem hiding this comment.
Correct the heading text from 'Customs filters' to 'Custom filters'.
| #### Customs filters | |
| #### Custom filters |
| } | ||
| ``` | ||
| #### Customs filters | ||
| It's possible to customize filters with differents options in JSON file |
There was a problem hiding this comment.
Correct 'differents' to 'different' (grammar) to improve readability.
| It's possible to customize filters with differents options in JSON file | |
| It's possible to customize filters with different options in JSON file |
| "prefixMatch": [ | ||
| "b" | ||
| ], | ||
| } |
There was a problem hiding this comment.
This example JSON is invalid due to the trailing comma after the array (line 175). Since this is documentation users will copy/paste, please make the snippet valid JSON (remove the trailing comma) and normalize indentation.
| "prefixMatch": [ | |
| "b" | |
| ], | |
| } | |
| "prefixMatch": [ | |
| "b" | |
| ] | |
| } |
| } | ||
| ``` | ||
|
|
||
| 3. For ALL BLOBS |
There was a problem hiding this comment.
Avoid ALL CAPS in headings and add a short explanation of why 1601-01-01T00:00:00Z represents 'all blobs' (e.g., it's the minimum supported creation time). Without this, readers may treat it as an arbitrary magic value.
| 3. For ALL BLOBS | |
| 3. For all blobs | |
| Use the minimum supported blob creation time so that all blobs are included: |
|
Can you review the proposed changes? IMPORTANT: When the changes are ready for publication, adding a #label:"aq-pr-triaged" |
prmerger-automator
bot
added
the
aq-pr-triaged
No description provided.