-
Notifications
You must be signed in to change notification settings - Fork 415
Solution upgrade using ARM template #3737
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
@ManikaDhiman : Thanks for your contribution! The author(s) and reviewer(s) have been notified to review your proposed change. |
Learn Build status updates of commit 1f12960:
|
Microsoft authors and contributors need to make content contributions through the private repository so the content can be staged and validated by the current validation rules. After you make your changes in the private repo, review the articles on staging, and fix any validation issues, you can add the sign-off comment to let PR reviewers know that the updates are ready to be merged. Read about authors working in the public repo](https://review.docs.microsoft.com/help/contribute/contribute-authors-in-public-repo?branch=main)) for more information. If you need help getting set up to work in the private repo, see Get started contributing to the Microsoft Learn platform. #assign: @v-sissondan |
Learn Build status updates of commit 3948748:
|
Learn Build status updates of commit e9c413f: 💡 Validation status: suggestions
azure-local/upgrade/media/install-solution-upgrade-azure-resource-manager-template/create-service-principal-1a.png
azure-local/upgrade/media/install-solution-upgrade-azure-resource-manager-template/create-service-principal-2a.png
azure-local/upgrade/media/install-solution-upgrade-azure-resource-manager-template/create-service-principal-2b.png
azure-local/upgrade/media/install-solution-upgrade-azure-resource-manager-template/deploy-arm-template-7a.png
azure-local/upgrade/media/install-solution-upgrade-azure-resource-manager-template/deploy-arm-template-7b.png
azure-local/upgrade/media/install-solution-upgrade-azure-resource-manager-template/get-azure-stackhci-object-id-1a.png
azure-local/upgrade/media/install-solution-upgrade-azure-resource-manager-template/search-azure-stackhci-resource-provider-1a.png
For more details, please refer to the build report. Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them. |
PRMerger Results
|
Learn Build status updates of commit 717c171: 💡 Validation status: suggestions
azure-local/upgrade/media/install-solution-upgrade-azure-resource-manager-template/get-azure-stackhci-object-id.png
azure-local/upgrade/media/install-solution-upgrade-azure-resource-manager-template/search-azure-stackhci-resource-provider-overview.png
For more details, please refer to the build report. Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them. |
PRMerger Results
|
Learn Build status updates of commit 5126f1f: ✅ Validation status: passed
For more details, please refer to the build report. |
PRMerger Results
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. Please see some suggestions inline.
Additional feedback: Deploy via ARM template has section for: KI for ARM template deployment, will these be applicable to the upgrade via ARM template as well? Please confirm.
azure-local/upgrade/install-solution-upgrade-azure-resource-manager-template.md
Outdated
Show resolved
Hide resolved
azure-local/upgrade/install-solution-upgrade-azure-resource-manager-template.md
Show resolved
Hide resolved
azure-local/upgrade/install-solution-upgrade-azure-resource-manager-template.md
Show resolved
Hide resolved
azure-local/upgrade/install-solution-upgrade-azure-resource-manager-template.md
Show resolved
Hide resolved
azure-local/upgrade/install-solution-upgrade-azure-resource-manager-template.md
Outdated
Show resolved
Hide resolved
To authenticate your system, you need to create a service principal and a corresponding **Client secret** for Arc Resource Bridge (ARB). | ||
|
||
### Create a service principal for ARB | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these the same steps that we have used in deploy via ARM template article? If so, consider using an include between the 2 articles?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll add the steps in include after completing tech review. Keeping the comment open until then.
You use the **Application (client) ID** against the `arbDeploymentAppID` parameter and the **Object ID** against the `arbDeploymentSPNObjectID` parameter in the Resource Manager template. | ||
|
||
### Create a client secret for ARB service principal | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Again is this the same procedure that we use for deploy via ARM template? If so, consider using include.
### Get the object ID for Azure Local Resource Provider | ||
|
||
This object ID for the Azure Local Resource Provide (RP) is unique per Azure tenant. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am assuming this procedure would be the same as what we used for deploy via ARM template too. Include here as well?
|
||
::: moniker range=">=azloc-2503" | ||
|
||
4. From the **Quickstart template (disclaimer)** dropdown list, select the **azurestackhci/upgrade-cluster** template. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Break down the following steps into these subsections (tweak section names):
Select a template
Basics tab
Review + Create tab
22. Refresh and watch the deployment progress from the first machine (also known as the seed machine and is the first machine where you deployed the cluster). Deployment takes between 2.5 and 3 hours. Several steps take 40-50 minutes or more. | ||
|
||
## ARM template parameters reference | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we are planning to add this parameters reference, definitely we should use an include. Another option is to put ARM template parameters reference in a standalone and link out to it.
@ManikaDhiman Added some feedback. Thank you! |
Learn Build status updates of commit 82e89ac: ✅ Validation status: passed
For more details, please refer to the build report. |
PRMerger Results
|
Learn Build status updates of commit b26a47d: ✅ Validation status: passed
For more details, please refer to the build report. |
PRMerger Results
|
No description provided.