Skip to content

Fix leaderboard API loading #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

fernandogutierrez27
Copy link

Following the Automate multi-container Kubernetes deployments with Azure Pipelines module, when I reached to the last step, the Leaderboard API was working fine, but the web couldn't be displayed because an error.

image

I debugged the application locally and found a few issues related to the LeaderboardResponse deserialization:

  1. JsonPropertyName attributes are missing in LeaderboardResponse class, so when JsonSerializer try to deserialize it, just returns 0 or null values.
  2. JsonPropertyName attributes are missing in ScoreProfile struct, so when JsonSerializer try to deserialize the LeaderBoard.Scores property just returns null values.
  3. The ScoreProfile struct use Score and Profile as fields, not properties. So, JsonSerializer must be configured to IncludeFields = true, otherwise the returned value for Score and Profile is null.

@ghost
Copy link

ghost commented Jun 28, 2021

CLA assistant check
All CLA requirements met.

@kasunsjc
Copy link

Please merge the pull request. without this app is not working

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants