Skip to content

Link fixes #12383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 22, 2024
Merged

Link fixes #12383

merged 4 commits into from
Nov 22, 2024

Conversation

chrisda
Copy link
Contributor

@chrisda chrisda commented Nov 22, 2024

And other formatting fixes

@github-actions GitHub Actions
Copy link

STOP Caution: Large pull request

This public repo applies limits on the number of files that can be merged in a single pull request (PR):

  • Warning Warning message and ability to unblock PR using the Merge large pull request* label - 30
  • Block Block message and PR is blocked - 100

This pull request will change 93 files, which exceeds the warning limit of 30.

Before this pull request can be merged, you must review the list of files it contains and their changes to confirm they are correct and intentional. This includes files you did not change and/or do not own. If there are changes you aren't familiar with, contact the individuals who submitted the commits included in this pull request and review the changes with them.

The individual who merges this pull request is responsible for ensuring the changes included in it are correct, and for resolving any issues that might result in merging it.

To merge this pull request

If you have determined that the changes in this pull request are correct, add the Merge large pull request* label to it, wait for the max/pr-file-count check to pass, and then click Merge. To add a label, click the gear icon next to Labels and then select Merge large pull request*.

Label UI screenshot

To reject this pull request

If you can't confirm the changes in this pull request are correct, click Close pull request at the bottom of this page to close it without merging. Work with your team to revert any changes that aren't correct.

* You must have write or triage access to this repo to add labels.

1 similar comment
@github-actions GitHub Actions
Copy link

STOP Caution: Large pull request

This public repo applies limits on the number of files that can be merged in a single pull request (PR):

  • Warning Warning message and ability to unblock PR using the Merge large pull request* label - 30
  • Block Block message and PR is blocked - 100

This pull request will change 93 files, which exceeds the warning limit of 30.

Before this pull request can be merged, you must review the list of files it contains and their changes to confirm they are correct and intentional. This includes files you did not change and/or do not own. If there are changes you aren't familiar with, contact the individuals who submitted the commits included in this pull request and review the changes with them.

The individual who merges this pull request is responsible for ensuring the changes included in it are correct, and for resolving any issues that might result in merging it.

To merge this pull request

If you have determined that the changes in this pull request are correct, add the Merge large pull request* label to it, wait for the max/pr-file-count check to pass, and then click Merge. To add a label, click the gear icon next to Labels and then select Merge large pull request*.

Label UI screenshot

To reject this pull request

If you can't confirm the changes in this pull request are correct, click Close pull request at the bottom of this page to close it without merging. Work with your team to revert any changes that aren't correct.

* You must have write or triage access to this repo to add labels.

@chrisda chrisda added Merge large pull request The pull request has more than 30 files, and the writer has confirmed that the changes are correct and removed Microsoft submitter labels Nov 22, 2024
@learn-build-service-prod Learn Build Service (PROD)
Copy link

Learn Build status updates of commit 27fa879:

⚠️ Validation status: warnings

File Status Preview URL Details
teams/teams-ps/teams/Set-CsExternalAccessPolicy.md ⚠️Warning View (teams-ps) Details
teams/teams-ps/teams/Remove-CsTeamsMeetingBrandingPolicy.md 💡Suggestion View (teams-ps) Details
teams/teams-ps/teams/Remove-CsOnlineApplicationInstanceAssociation.md ✅Succeeded View (teams-ps)
teams/teams-ps/teams/Remove-CsOnlineAudioFile.md ✅Succeeded View (teams-ps)
teams/teams-ps/teams/Remove-CsOnlineDialInConferencingTenantSettings.md ✅Succeeded View (teams-ps)
teams/teams-ps/teams/Remove-CsOnlineLisCivicAddress.md ✅Succeeded View (teams-ps)
teams/teams-ps/teams/Remove-CsOnlineLisLocation.md ✅Succeeded View (teams-ps)
teams/teams-ps/teams/Remove-CsOnlineLisPort.md ✅Succeeded View (teams-ps)
teams/teams-ps/teams/Remove-CsOnlineLisSwitch.md ✅Succeeded View (teams-ps)
teams/teams-ps/teams/Remove-CsOnlineLisWirelessAccessPoint.md ✅Succeeded View (teams-ps)
teams/teams-ps/teams/Remove-CsOnlinePSTNGateway.md ✅Succeeded View (teams-ps)
teams/teams-ps/teams/Remove-CsOnlineSchedule.md ✅Succeeded View (teams-ps)
teams/teams-ps/teams/Remove-CsOnlineTelephoneNumber.md ✅Succeeded View (teams-ps)
teams/teams-ps/teams/Remove-CsOnlineVoicemailPolicy.md ✅Succeeded View (teams-ps)
teams/teams-ps/teams/Remove-CsOnlineVoiceRoute.md ✅Succeeded View (teams-ps)
teams/teams-ps/teams/Remove-CsOnlineVoiceRoutingPolicy.md ✅Succeeded View (teams-ps)
teams/teams-ps/teams/Remove-CsPhoneNumberAssignment.md ✅Succeeded View (teams-ps)
teams/teams-ps/teams/Remove-CsTeamsAIPolicy.md ✅Succeeded View (teams-ps)
teams/teams-ps/teams/Remove-CsTeamsAppPermissionPolicy.md ✅Succeeded View (teams-ps)
teams/teams-ps/teams/Remove-CsTeamsAppSetupPolicy.md ✅Succeeded View (teams-ps)
teams/teams-ps/teams/Remove-CsTeamsAudioConferencingPolicy.md ✅Succeeded View (teams-ps)
teams/teams-ps/teams/Remove-CsTeamsCallHoldPolicy.md ✅Succeeded View (teams-ps)
teams/teams-ps/teams/Remove-CsTeamsCallingPolicy.md ✅Succeeded View (teams-ps)
teams/teams-ps/teams/Remove-CsTeamsCallParkPolicy.md ✅Succeeded View (teams-ps)
teams/teams-ps/teams/Remove-CsTeamsChannelsPolicy.md ✅Succeeded View (teams-ps)

This comment lists only the first 25 files in the pull request.

teams/teams-ps/teams/Set-CsExternalAccessPolicy.md

  • Line 0, Column 0: [Warning: file-not-found - See documentation] Invalid file link: 'set-csteamsacsfederationconfiguration'.
  • Line 0, Column 0: [Suggestion: learn-site-link-broken - See documentation] Link 'https://learn.microsoft.com/powershell/module/teams//azure/communication-services/concepts/teams-interop' points to a learn site page that doesn't exist. Check the path or URL and update the link.

teams/teams-ps/teams/Remove-CsTeamsMeetingBrandingPolicy.md

  • Line 0, Column 0: [Suggestion: ms-author-invalid - See documentation] Invalid value for 'ms.author', 'szymonkatra' is not a valid Microsoft alias.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@chrisda
Update Set-CsExternalAccessPolicy.md
3bc5436 
Link fixes per build report
@learn-build-service-prod Learn Build Service (PROD)
Copy link

Learn Build status updates of commit 96bed8e:

⚠️ Validation status: warnings

File Status Preview URL Details
teams/teams-ps/teams/Set-CsExternalAccessPolicy.md ⚠️Warning View (teams-ps) Details
teams/teams-ps/teams/Remove-CsTeamsMeetingBrandingPolicy.md 💡Suggestion View (teams-ps) Details
teams/teams-ps/teams/Remove-CsOnlineApplicationInstanceAssociation.md ✅Succeeded View (teams-ps)
teams/teams-ps/teams/Remove-CsOnlineAudioFile.md ✅Succeeded View (teams-ps)
teams/teams-ps/teams/Remove-CsOnlineDialInConferencingTenantSettings.md ✅Succeeded View (teams-ps)
teams/teams-ps/teams/Remove-CsOnlineLisCivicAddress.md ✅Succeeded View (teams-ps)
teams/teams-ps/teams/Remove-CsOnlineLisLocation.md ✅Succeeded View (teams-ps)
teams/teams-ps/teams/Remove-CsOnlineLisPort.md ✅Succeeded View (teams-ps)
teams/teams-ps/teams/Remove-CsOnlineLisSwitch.md ✅Succeeded View (teams-ps)
teams/teams-ps/teams/Remove-CsOnlineLisWirelessAccessPoint.md ✅Succeeded View (teams-ps)
teams/teams-ps/teams/Remove-CsOnlinePSTNGateway.md ✅Succeeded View (teams-ps)
teams/teams-ps/teams/Remove-CsOnlineSchedule.md ✅Succeeded View (teams-ps)
teams/teams-ps/teams/Remove-CsOnlineTelephoneNumber.md ✅Succeeded View (teams-ps)
teams/teams-ps/teams/Remove-CsOnlineVoicemailPolicy.md ✅Succeeded View (teams-ps)
teams/teams-ps/teams/Remove-CsOnlineVoiceRoute.md ✅Succeeded View (teams-ps)
teams/teams-ps/teams/Remove-CsOnlineVoiceRoutingPolicy.md ✅Succeeded View (teams-ps)
teams/teams-ps/teams/Remove-CsPhoneNumberAssignment.md ✅Succeeded View (teams-ps)
teams/teams-ps/teams/Remove-CsTeamsAIPolicy.md ✅Succeeded View (teams-ps)
teams/teams-ps/teams/Remove-CsTeamsAppPermissionPolicy.md ✅Succeeded View (teams-ps)
teams/teams-ps/teams/Remove-CsTeamsAppSetupPolicy.md ✅Succeeded View (teams-ps)
teams/teams-ps/teams/Remove-CsTeamsAudioConferencingPolicy.md ✅Succeeded View (teams-ps)
teams/teams-ps/teams/Remove-CsTeamsCallHoldPolicy.md ✅Succeeded View (teams-ps)
teams/teams-ps/teams/Remove-CsTeamsCallingPolicy.md ✅Succeeded View (teams-ps)
teams/teams-ps/teams/Remove-CsTeamsCallParkPolicy.md ✅Succeeded View (teams-ps)
teams/teams-ps/teams/Remove-CsTeamsChannelsPolicy.md ✅Succeeded View (teams-ps)

This comment lists only the first 25 files in the pull request.

teams/teams-ps/teams/Set-CsExternalAccessPolicy.md

  • Line 0, Column 0: [Warning: file-not-found - See documentation] Invalid file link: 'set-csteamsacsfederationconfiguration'.
  • Line 0, Column 0: [Suggestion: learn-site-link-broken - See documentation] Link 'https://learn.microsoft.com/powershell/module/teams//azure/communication-services/concepts/teams-interop' points to a learn site page that doesn't exist. Check the path or URL and update the link.

teams/teams-ps/teams/Remove-CsTeamsMeetingBrandingPolicy.md

  • Line 0, Column 0: [Suggestion: ms-author-invalid - See documentation] Invalid value for 'ms.author', 'szymonkatra' is not a valid Microsoft alias.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@github-actions GitHub Actions
Copy link

STOP Caution: Large pull request

This public repo applies limits on the number of files that can be merged in a single pull request (PR):

  • Warning Warning message and ability to unblock PR using the Merge large pull request* label - 30
  • Block Block message and PR is blocked - 100

This pull request will change 93 files, which exceeds the warning limit of 30.

Before this pull request can be merged, you must review the list of files it contains and their changes to confirm they are correct and intentional. This includes files you did not change and/or do not own. If there are changes you aren't familiar with, contact the individuals who submitted the commits included in this pull request and review the changes with them.

The individual who merges this pull request is responsible for ensuring the changes included in it are correct, and for resolving any issues that might result in merging it.

To merge this pull request

If you have determined that the changes in this pull request are correct, add the Merge large pull request* label to it, wait for the max/pr-file-count check to pass, and then click Merge. To add a label, click the gear icon next to Labels and then select Merge large pull request*.

Label UI screenshot

To reject this pull request

If you can't confirm the changes in this pull request are correct, click Close pull request at the bottom of this page to close it without merging. Work with your team to revert any changes that aren't correct.

* You must have write or triage access to this repo to add labels.

@github-actions github-actions bot removed the Merge large pull request The pull request has more than 30 files, and the writer has confirmed that the changes are correct label Nov 22, 2024
@chrisda chrisda added the Merge large pull request The pull request has more than 30 files, and the writer has confirmed that the changes are correct label Nov 22, 2024
@learn-build-service-prod Learn Build Service (PROD)
Copy link

Learn Build status updates of commit bbb4707:

💡 Validation status: suggestions

File Status Preview URL Details
teams/teams-ps/teams/Remove-CsTeamsMeetingBrandingPolicy.md 💡Suggestion View (teams-ps) Details
teams/teams-ps/teams/Remove-CsOnlineApplicationInstanceAssociation.md ✅Succeeded View (teams-ps)
teams/teams-ps/teams/Remove-CsOnlineAudioFile.md ✅Succeeded View (teams-ps)
teams/teams-ps/teams/Remove-CsOnlineDialInConferencingTenantSettings.md ✅Succeeded View (teams-ps)
teams/teams-ps/teams/Remove-CsOnlineLisCivicAddress.md ✅Succeeded View (teams-ps)
teams/teams-ps/teams/Remove-CsOnlineLisLocation.md ✅Succeeded View (teams-ps)
teams/teams-ps/teams/Remove-CsOnlineLisPort.md ✅Succeeded View (teams-ps)
teams/teams-ps/teams/Remove-CsOnlineLisSwitch.md ✅Succeeded View (teams-ps)
teams/teams-ps/teams/Remove-CsOnlineLisWirelessAccessPoint.md ✅Succeeded View (teams-ps)
teams/teams-ps/teams/Remove-CsOnlinePSTNGateway.md ✅Succeeded View (teams-ps)
teams/teams-ps/teams/Remove-CsOnlineSchedule.md ✅Succeeded View (teams-ps)
teams/teams-ps/teams/Remove-CsOnlineTelephoneNumber.md ✅Succeeded View (teams-ps)
teams/teams-ps/teams/Remove-CsOnlineVoicemailPolicy.md ✅Succeeded View (teams-ps)
teams/teams-ps/teams/Remove-CsOnlineVoiceRoute.md ✅Succeeded View (teams-ps)
teams/teams-ps/teams/Remove-CsOnlineVoiceRoutingPolicy.md ✅Succeeded View (teams-ps)
teams/teams-ps/teams/Remove-CsPhoneNumberAssignment.md ✅Succeeded View (teams-ps)
teams/teams-ps/teams/Remove-CsTeamsAIPolicy.md ✅Succeeded View (teams-ps)
teams/teams-ps/teams/Remove-CsTeamsAppPermissionPolicy.md ✅Succeeded View (teams-ps)
teams/teams-ps/teams/Remove-CsTeamsAppSetupPolicy.md ✅Succeeded View (teams-ps)
teams/teams-ps/teams/Remove-CsTeamsAudioConferencingPolicy.md ✅Succeeded View (teams-ps)
teams/teams-ps/teams/Remove-CsTeamsCallHoldPolicy.md ✅Succeeded View (teams-ps)
teams/teams-ps/teams/Remove-CsTeamsCallingPolicy.md ✅Succeeded View (teams-ps)
teams/teams-ps/teams/Remove-CsTeamsCallParkPolicy.md ✅Succeeded View (teams-ps)
teams/teams-ps/teams/Remove-CsTeamsChannelsPolicy.md ✅Succeeded View (teams-ps)
teams/teams-ps/teams/Remove-CsTeamsComplianceRecordingApplication.md ✅Succeeded View (teams-ps)

This comment lists only the first 25 files in the pull request.

teams/teams-ps/teams/Remove-CsTeamsMeetingBrandingPolicy.md

  • Line 0, Column 0: [Suggestion: ms-author-invalid - See documentation] Invalid value for 'ms.author', 'szymonkatra' is not a valid Microsoft alias.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@chrisda chrisda merged commit d5bf41c into main Nov 22, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@tomkau tomkau

@SerdarSoysal SerdarSoysal

@ashishguptaiitb ashishguptaiitb

@aditdalvi aditdalvi

@saleens7 saleens7

Labels

Merge large pull request The pull request has more than 30 files, and the writer has confirmed that the changes are correct Microsoft submitter

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@chrisda @tomkau @SerdarSoysal @ashishguptaiitb @aditdalvi @saleens7