Skip to content

Conversation

michelle-paradis
Copy link
Contributor

@michelle-paradis michelle-paradis commented Jan 14, 2025

PubOps feedback comment

--

Create the Microsoft Docs for the Update-M365UnifiedCustomPendingApp powershell commandlet.

Copy link

Learn Build status updates of commit bf03e33:

✅ Validation status: passed

File Status Preview URL Details
teams/teams-ps/teams/Update-M365UnifiedCustomPendingApp ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

Copy link

Learn Build status updates of commit 1ea6cf1:

✅ Validation status: passed

File Status Preview URL Details
teams/teams-ps/teams/Update-M365UnifiedCustomPendingApp ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

Copy link

Learn Build status updates of commit 693240f:

💡 Validation status: suggestions

File Status Preview URL Details
teams/teams-ps/teams/Update-M365UnifiedCustomPendingApp.md 💡Suggestion View (teams-ps) Details

teams/teams-ps/teams/Update-M365UnifiedCustomPendingApp.md

  • Line 0, Column 0: [Suggestion: ms-author-invalid - See documentation] Invalid value for 'ms.author', 'michelle-paradis' is not a valid Microsoft alias.
  • Line 0, Column 0: [Suggestion: learn-site-link-broken - See documentation] Link 'https://learn.microsoft.com/powershell/module/teams/Get-M365UnifiedCustomPendingApps' points to a learn site page that doesn't exist. Check the path or URL and update the link.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

Copy link

Learn Build status updates of commit fbffc08:

💡 Validation status: suggestions

File Status Preview URL Details
teams/teams-ps/teams/Update-M365UnifiedCustomPendingApp.md 💡Suggestion View (teams-ps) Details

teams/teams-ps/teams/Update-M365UnifiedCustomPendingApp.md

  • Line 0, Column 0: [Suggestion: learn-site-link-broken - See documentation] Link 'https://learn.microsoft.com/powershell/module/teams/Get-M365UnifiedCustomPendingApps' points to a learn site page that doesn't exist. Check the path or URL and update the link.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@michbrown-png michbrown-png added the Sign off The pull request is ready to be reviewed and merged by PubOps label Jan 16, 2025
@aditisrivastava07 aditisrivastava07 self-assigned this Jan 16, 2025
@aditisrivastava07 aditisrivastava07 added the In review PubOps is reviewing the pull request label Jan 16, 2025
Copy link

Learn Build status updates of commit ec5dea1:

💡 Validation status: suggestions

File Status Preview URL Details
teams/teams-ps/teams/Update-M365UnifiedCustomPendingApp.md 💡Suggestion View (teams-ps) Details

teams/teams-ps/teams/Update-M365UnifiedCustomPendingApp.md

  • Line 0, Column 0: [Suggestion: learn-site-link-broken - See documentation] Link 'https://learn.microsoft.com/powershell/module/teams/Get-M365UnifiedCustomPendingApps' points to a learn site page that doesn't exist. Check the path or URL and update the link.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@aditisrivastava07
Copy link
Contributor

Hi @michelle-paradis,

Following is a blocking issue that needs to be resolved before we can merge:

teams/teams-ps/teams/Update-M365UnifiedCustomPendingApp.md

  • Line 96: The link is broken and gives error 404 page not found. Format the link so that it resolves correctly. Also, use site-relative or file-relative link rather than an absolute link.

Reference

Criteria used for pull request reviews

Blocking

  • All links resolve correctly.
  • Links to other files in Microsoft Learn aren't absolute (full-path) URLs:
    • For links to files in the same doc set (folder), use file-relative links (and include the file name extension).
      • Example: safe-attachments.md
    • For links to files in different doc sets (folders) or repos, use site-relative links (and don't include the file name extension).
      • Example: /microsoft-365/security/defender-365-security/safe-attachments

After you resolve the blocking issues, remove the Back to submitter label and add the Sign off label again.

If you need help resolving issues in this PR, post your question in the Ask an Admin Teams Channel.

Thanks, Aditi

@aditisrivastava07 aditisrivastava07 added Back to submitter The pull request didn't pass the review criteria and has been returned to the writer for updates and removed In review PubOps is reviewing the pull request Sign off The pull request is ready to be reviewed and merged by PubOps labels Jan 16, 2025
@michelle-paradis
Copy link
Contributor Author

Hi @aditisrivastava07, I've resolved your comments! Please take a look at the PR again.

Copy link

Learn Build status updates of commit 9c05ed2:

✅ Validation status: passed

File Status Preview URL Details
teams/teams-ps/teams/Update-M365UnifiedCustomPendingApp.md ✅Succeeded View (teams-ps)

For more details, please refer to the build report.

For any questions, please:

@michelle-paradis
Copy link
Contributor Author

@michbrown-png, can you add the 'Sign off' label again and remove the 'Back to submitter' label? I don't seem to have access to do this.

Copy link

Learn Build status updates of commit 207af22:

✅ Validation status: passed

File Status Preview URL Details
teams/teams-ps/teams/Update-M365UnifiedCustomPendingApp.md ✅Succeeded View (teams-ps)

For more details, please refer to the build report.

For any questions, please:

Copy link

Learn Build status updates of commit 7a313d4:

✅ Validation status: passed

File Status Preview URL Details
teams/teams-ps/teams/Update-M365UnifiedCustomPendingApp.md ✅Succeeded View (teams-ps)

For more details, please refer to the build report.

For any questions, please:

Copy link

Learn Build status updates of commit b1a61ba:

✅ Validation status: passed

File Status Preview URL Details
teams/teams-ps/teams/Update-M365UnifiedCustomPendingApp.md ✅Succeeded View (teams-ps)

For more details, please refer to the build report.

For any questions, please:

Copy link

Learn Build status updates of commit c91ba5c:

❌ Validation status: errors

Please follow instructions here which may help to resolve issue.

File Status Preview URL Details
teams/teams-ps/teams/Update-M365UnifiedCustomPendingApp.md ❌Error Details
teams/teams-ps/teams/index.yml ⚠️Warning Details

teams/teams-ps/teams/Update-M365UnifiedCustomPendingApp.md

  • Line 0, Column 0: [Error: MAML2Yaml_LoadFileFailed]
Failed to load file: C:/LocalRun/W/othd-s/teams/teams-ps/teams/Update-M365UnifiedCustomPendingApp.md:76:(779) '### System.Object'
 Expect Heading, please try to use PlatyPS validate the content

teams/teams-ps/teams/index.yml

  • Line 259, Column 5: [Warning: xref-not-found - See documentation] Cross reference not found: 'MicrosoftTeamsPowerShell.New-CsCloudCallDataConnection'.
  • Line 337, Column 5: [Warning: xref-not-found - See documentation] Cross reference not found: 'MicrosoftTeamsPowerShell.New-CsTenantNetworkRegion'.
  • Line 415, Column 5: [Warning: xref-not-found - See documentation] Cross reference not found: 'MicrosoftTeamsPowerShell.Remove-CsTeamsTranslationRule'.
  • Line 445, Column 5: [Warning: xref-not-found - See documentation] Cross reference not found: 'MicrosoftTeamsPowerShell.Set-CsExternalAccessPolicy'.
  • Line 455, Column 5: [Warning: xref-not-found - See documentation] Cross reference not found: 'MicrosoftTeamsPowerShell.Set-CsOnlineDialInConferencingUserDefaultNumber'.
  • Line 460, Column 5: [Warning: xref-not-found - See documentation] Cross reference not found: 'MicrosoftTeamsPowerShell.Set-CsOnlineLisSubnet'.
  • Line 461, Column 5: [Warning: xref-not-found - See documentation] Cross reference not found: 'MicrosoftTeamsPowerShell.Set-CsOnlineLisSwitch'.
  • Line 473, Column 5: [Warning: xref-not-found - See documentation] Cross reference not found: 'MicrosoftTeamsPowerShell.Set-CsTeamsAcsFederationConfiguration'.
  • Line 476, Column 5: [Warning: xref-not-found - See documentation] Cross reference not found: 'MicrosoftTeamsPowerShell.Set-CsTeamsAppSetupPolicy'.
  • Line 477, Column 5: [Warning: xref-not-found - See documentation] Cross reference not found: 'MicrosoftTeamsPowerShell.Set-CsTeamsAudioConferencingPolicy'.
  • Line 484, Column 5: [Warning: xref-not-found - See documentation] Cross reference not found: 'MicrosoftTeamsPowerShell.Set-CsTeamsComplianceRecordingPolicy'.
  • Line 485, Column 5: [Warning: xref-not-found - See documentation] Cross reference not found: 'MicrosoftTeamsPowerShell.Set-CsTeamsCortanaPolicy'.
  • Line 508, Column 5: [Warning: xref-not-found - See documentation] Cross reference not found: 'MicrosoftTeamsPowerShell.Set-CsTeamsMobilityPolicy'.
  • Line 512, Column 5: [Warning: xref-not-found - See documentation] Cross reference not found: 'MicrosoftTeamsPowerShell.Set-CsTeamsPinnedApp'.
  • Line 519, Column 5: [Warning: xref-not-found - See documentation] Cross reference not found: 'MicrosoftTeamsPowerShell.Set-CsTeamsShiftsConnectionInstance'.
  • Line 521, Column 5: [Warning: xref-not-found - See documentation] Cross reference not found: 'MicrosoftTeamsPowerShell.Set-CsTeamsSipDevicesConfiguration'.
  • Line 526, Column 5: [Warning: xref-not-found - See documentation] Cross reference not found: 'MicrosoftTeamsPowerShell.Set-CsTeamsTranslationRule'.
  • Line 527, Column 5: [Warning: xref-not-found - See documentation] Cross reference not found: 'MicrosoftTeamsPowerShell.Set-CsTeamsUnassignedNumberTreatment'.
  • Line 533, Column 5: [Warning: xref-not-found - See documentation] Cross reference not found: 'MicrosoftTeamsPowerShell.Set-CsTeamsWorkLoadPolicy'.
  • Line 539, Column 5: [Warning: xref-not-found - See documentation] Cross reference not found: 'MicrosoftTeamsPowerShell.Set-CsTenantNetworkRegion'.
  • Line 540, Column 5: [Warning: xref-not-found - See documentation] Cross reference not found: 'MicrosoftTeamsPowerShell.Set-CsTenantNetworkSite'.
  • Line 541, Column 5: [Warning: xref-not-found - See documentation] Cross reference not found: 'MicrosoftTeamsPowerShell.Set-CsTenantNetworkSubnet'.
  • Line 544, Column 5: [Warning: xref-not-found - See documentation] Cross reference not found: 'MicrosoftTeamsPowerShell.Set-CsUserCallingDelegate'.
  • Line 545, Column 5: [Warning: xref-not-found - See documentation] Cross reference not found: 'MicrosoftTeamsPowerShell.Set-CsUserCallingSettings'.

This comment lists only the first 25 errors (including error/warning/suggestion) in the pull request.
For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

Copy link

Learn Build status updates of commit bff4d79:

❌ Validation status: errors

Please follow instructions here which may help to resolve issue.

File Status Preview URL Details
teams/teams-ps/teams/Update-M365UnifiedCustomPendingApp.md ❌Error Details
teams/teams-ps/teams/index.yml ⚠️Warning Details

teams/teams-ps/teams/Update-M365UnifiedCustomPendingApp.md

  • Line 0, Column 0: [Error: MAML2Yaml_LoadFileFailed]
Failed to load file: C:/LocalRun/W/4dru-s/teams/teams-ps/teams/Update-M365UnifiedCustomPendingApp.md:76:(779) '### System.Object'
 Expect Heading, please try to use PlatyPS validate the content

teams/teams-ps/teams/index.yml

  • Line 573, Column 5: [Warning: xref-not-found - See documentation] Cross reference not found: 'MicrosoftTeamsPowerShell.Update-M365UnifiedCustomPendingApp'.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

Copy link

Learn Build status updates of commit 8a93552:

✅ Validation status: passed

File Status Preview URL Details
teams/teams-ps/teams/teams.md ✅Succeeded View (teams-ps)
teams/teams-ps/teams/Update-M365UnifiedCustomPendingApp.md ✅Succeeded View (teams-ps)

For more details, please refer to the build report.

For any questions, please:

@michbrown-png michbrown-png added Sign off The pull request is ready to be reviewed and merged by PubOps and removed Back to submitter The pull request didn't pass the review criteria and has been returned to the writer for updates labels Jan 23, 2025
@Ruchika-mittal01 Ruchika-mittal01 self-assigned this Jan 23, 2025
@Ruchika-mittal01 Ruchika-mittal01 added the In review PubOps is reviewing the pull request label Jan 23, 2025
@Ruchika-mittal01 Ruchika-mittal01 merged commit d36dd9c into MicrosoftDocs:main Jan 23, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:teams In review PubOps is reviewing the pull request Microsoft submitter Sign off The pull request is ready to be reviewed and merged by PubOps

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants