Add DST ambiguity note to TzSpecificLocalTimeToSystemTime(Ex) documentation #2065
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR updates the Remarks section of the TzSpecificLocalTimeToSystemTime API documentation to clarify behavior around Daylight Saving Time (DST) transitions. Specifically, it adds a note explaining that: Certain local times near DST transitions may be ambiguous (e.g., repeated during fall back) or invalid (e.g., skipped during spring forward). The API may not return the "correct" UTC value in these cases due to the lack of a DST indicator in the SYSTEMTIME structure. Developers should be aware of this limitation and consider alternative approaches for time-sensitive operations. This clarification is based on internal bug reports and developer feedback, and aims to prevent confusion and misinterpretation of API behavior during DST transitions. ✅ Motivation: Improve developer understanding of edge cases in time conversion. Reduce misuses and incorrect assumptions about API behavior near DST boundaries. Align documentation with observed behavior and internal guidance.
…as the non-Ex version
|
@microsoft-github-policy-service agree company="Microsoft" |
|
@rkg96 : Thanks for your contribution! The author(s) and reviewer(s) have been notified to review your proposed change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the Remarks section of the TzSpecificLocalTimeToSystemTime and TzSpecificLocalTimeToSystemTimeEx APIs documentation to clarify behavior around Daylight Saving Time (DST) transitions.
Specifically, it adds a note explaining that:
This clarification is based on MSFT-internal bug reports and developer feedback and aims to prevent confusion and misinterpretation of API behavior during DST transitions.