Skip to content

Conversation

MarekVCodasip
Copy link

No description provided.

Copy link

@MarekVCodasip : Thanks for your contribution! The author(s) and reviewer(s) have been notified to review your proposed change.

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR clarifies the documentation for the Winsock2 select() function by specifying that the function fails not only when all three descriptor parameters are null, but also when they are empty.

  • Updates error condition documentation to include empty descriptor parameters as a failure case

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

</td>
<td width="60%">
The <i>time-out</i> value is not valid, or all three descriptor parameters were <b>null</b>.
The <i>time-out</i> value is not valid, or all three descriptor parameters were <b>null</b> or descriptor parameters are empty.
Copy link
Preview

Copilot AI Sep 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] The sentence structure is unclear due to missing articles. Consider rewording to: 'The time-out value is not valid, or all three descriptor parameters were null or the descriptor parameters are empty.'

Suggested change
The <i>time-out</i> value is not valid, or all three descriptor parameters were <b>null</b> or descriptor parameters are empty.
The <i>time-out</i> value is not valid, or all three descriptor parameters were <b>null</b> or the descriptor parameters are empty.

Copilot uses AI. Check for mistakes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants