-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Add missing Scale qualifier default value information and warnings to build-resources-into-app-package.md #5614
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: docs
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot wasn't able to review any files in this pull request.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Learn Build status updates of commit fcc0c92:
|
Co-authored-by: alvinashcraft <[email protected]>
Learn Build status updates of commit 63663ba: ✅ Validation status: passed
For more details, please refer to the build report. |
Learn Build status updates of commit 090aa24: ✅ Validation status: passed
For more details, please refer to the build report. |
The documentation for Option 2 in "Build resources into your app package" was missing critical information about how
<AppxDefaultResourceQualifiers>
overrides ALL default qualifier values, not just the ones specified. This caused users to lose built-in defaults likeScale=200
, resulting in missing scaled images in packaged apps.Problem
When users followed the documentation to add:
They would lose the built-in
Scale=200
default and other qualifier defaults, causing their apps to be missing 200% scale images and other resources.Solution
<AppxDefaultResourceQualifiers>
replaces ALL defaultsScale=200
and all other default qualifierspriconfig.default.xml
examplesThe changes directly address the specific issue of missing scaled images while providing comprehensive guidance for all qualifier defaults.
Fixes #4344.
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.