Skip to content

Conversation

@Rudxain
Copy link
Contributor

@Rudxain Rudxain commented Oct 11, 2024

Important

I haven't compiled it yet!

Edit: I've noticed there's a CI that does cargo check 😅

Copy link
Owner

@MidasLamb MidasLamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! Could you maybe elaborate on why you need this function exactly? I wouldn't image the is_empty check to have any considerable overhead in most cases?

@Rudxain
Copy link
Contributor Author

Rudxain commented Oct 12, 2024

Thanks for the contribution!

You're welcome!

Could you maybe elaborate on why you need this function exactly?

Mostly for consistency with core. But it can also help optimize surrounding code, not just the conversion (similarly to unchecked_add)

Copy link
Owner

@MidasLamb MidasLamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

@MidasLamb MidasLamb merged commit fc79ad4 into MidasLamb:master Oct 15, 2024
3 of 4 checks passed
@Rudxain Rudxain deleted the uncheck branch October 16, 2024 04:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants