Merge pull request #306 from shijinpjlab/dev_1222

feat: fix bug gradio detail repeat

Author: shijinpjlab

app_gradio/app.py

@@ -156,7 +156,7 @@ def dingo_demo(
             "executor": {
                 "result_save": {
                     "bad": True,
-                    "good": True
+                    # "raw": True
                 },
                 "max_workers": max_workers,
                 "batch_size": batch_size,
@@ -176,9 +176,12 @@ def dingo_demo(
         executor = Executor.exec_map["local"](input_args)
         summary = executor.execute().to_dict()
         detail = executor.get_bad_info_list()
+        dingo_id_set = set()
         new_detail = []
         for item in detail:
-            new_detail.append(item)
+            if item['dingo_id'] not in dingo_id_set:
+                dingo_id_set.add(item['dingo_id'])
+                new_detail.append(item)
         if summary['output_path']:
             if remove_output == "true":
                 shutil.rmtree(summary['output_path'])

dingo/model/rule/rule_common.py

@@ -33,7 +33,9 @@ def eval(cls, input_data: Data) -> EvalDetail:
                 res.status = True
                 # res.merge(tmp_res)
                 res.label = [f"{cls.metric_type}.{cls.__name__}"]
-                res.reason = [] if res.reason is None else res.reason.extend(tmp_res.reason)
+                if res.reason is None:
+                    res.reason = []
+                res.reason.extend(tmp_res.reason)
         # Set QUALITY_GOOD when all checks pass
         if not res.status:
             res.label = [QualityLabel.QUALITY_GOOD]
@@ -63,7 +65,9 @@ def eval(cls, input_data: Data) -> EvalDetail:
                 res.status = True
                 # res.merge(tmp_res)
                 res.label = [f"{cls.metric_type}.{cls.__name__}"]
-                res.reason = [] if res.reason is None else res.reason.extend(tmp_res.reason)
+                if res.reason is None:
+                    res.reason = []
+                res.reason.extend(tmp_res.reason)
         # Set QUALITY_GOOD when all checks pass
         if not res.status:
             res.label = [QualityLabel.QUALITY_GOOD]
@@ -647,7 +651,9 @@ def eval(cls, input_data: Data) -> EvalDetail:
                 res.status = True
                 # res.merge(tmp_res)
                 res.label = [f"{cls.metric_type}.{cls.__name__}"]
-                res.reason = [] if res.reason is None else res.reason.extend(tmp_res.reason)
+                if res.reason is None:
+                    res.reason = []
+                res.reason.extend(tmp_res.reason)
         # Set QUALITY_GOOD when all checks pass
         if not res.status:
             res.label = [QualityLabel.QUALITY_GOOD]