refactor: enhance LocalExecutor to support separate thread and proces… #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s pools for evaluation - Updated LocalExecutor to utilize both ThreadPoolExecutor and ProcessPoolExecutor based on input arguments for improved concurrency. - Modified InputArgs to replace max_workers with process_num and thread_num for clearer configuration. - Use tqdm for each item
del-zhenwu
reviewed
Jan 9, 2025
dingo/run/cli.py
Outdated
| parser.add_argument("--process_workers", type=int, | ||
| default=None, help="The number of process workers to concurrent check. ") | ||
| parser.add_argument("--thread_workers", type=int, | ||
| default=None, help="The number of thread workers to concurrent check. ") |
Collaborator
There was a problem hiding this comment.
Can we expose only one argument for users? I would be confused when there are two parameters. So I prefer the orginal name max_workers
shijinpjlab
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…s pools for evaluation