-
Notifications
You must be signed in to change notification settings - Fork 65
docs: update README #299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: update README #299
Conversation
Summary of ChangesHello @e06084, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on improving the clarity and completeness of the documentation for custom rule implementation across the English, Japanese, and Simplified Chinese README files. The changes aim to provide more practical and consistent code examples, making it easier for users to understand how to define and utilize custom evaluation rules within the system. This enhancement ensures that the documentation is more user-friendly and accurate, particularly for those looking to extend the system's evaluation capabilities. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request provides helpful updates to the README files in English, Japanese, and Chinese. The code examples for custom rules are now more illustrative and correct, particularly with the addition of the required metric parameter to EvalDetail initializations. My review includes a few minor suggestions to further improve the clarity of one of the examples for users who might copy the code.
| return EvalDetail( | ||
| metric=cls.__name__, | ||
| status=True, # Found an issue | ||
| label=[f'{cls.metric_type}.{cls.__name__}'], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This example is a great improvement. For better clarity, since cls.metric_type is defined by the @Model.rule_register decorator which isn't visible in this snippet, consider adding a small inline comment to explain where it comes from. This will help users understand the example more easily.
| label=[f'{cls.metric_type}.{cls.__name__}'], | |
| label=[f'{cls.metric_type}.{cls.__name__}'], # metric_type is set by the @Model.rule_register decorator |
| return EvalDetail( | ||
| metric=cls.__name__, | ||
| status=True, # 問題を発見 | ||
| label=[f'{cls.metric_type}.{cls.__name__}'], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This example is a great improvement. For better clarity, since cls.metric_type is defined by the @Model.rule_register decorator which isn't visible in this snippet, consider adding a small inline comment to explain where it comes from. This will help users understand the example more easily.
| label=[f'{cls.metric_type}.{cls.__name__}'], | |
| label=[f'{cls.metric_type}.{cls.__name__}'], # metric_type is set by the @Model.rule_register decorator |
| return EvalDetail( | ||
| metric=cls.__name__, | ||
| status=True, # 发现问题 | ||
| label=[f'{cls.metric_type}.{cls.__name__}'], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This example is a great improvement. For better clarity, since cls.metric_type is defined by the @Model.rule_register decorator which isn't visible in this snippet, consider adding a small inline comment to explain where it comes from. This will help users understand the example more easily.
| label=[f'{cls.metric_type}.{cls.__name__}'], | |
| label=[f'{cls.metric_type}.{cls.__name__}'], # metric_type is set by the @Model.rule_register decorator |
No description provided.