-
Notifications
You must be signed in to change notification settings - Fork 65
build: set numpy>=1.26.4 #301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @e06084, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the version constraint for the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request changes the numpy dependency from being pinned to a specific version to allowing any version greater than or equal to 1.26.4. While this adds flexibility, it creates a risk of the project breaking with future numpy releases. Specifically, the upcoming NumPy 2.0 has known breaking changes. My feedback suggests adding an upper version limit to the dependency to prevent compatibility issues while still allowing for minor updates.
| pyahocorasick | ||
| nltk | ||
| numpy==1.26.4 | ||
| numpy>=1.26.4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While loosening the version constraint for numpy provides flexibility, using an open-ended >= is risky. The upcoming NumPy 2.0 release contains significant breaking API changes that will likely break this project. It's a safer practice to specify an upper bound to prevent your project from automatically installing incompatible major versions. This will ensure stability while still allowing for patch and minor updates.
numpy>=1.26.4, <2.0
No description provided.