Avoid errors if handler._populateQPMeta is missing#30
Open
rwjblue wants to merge 1 commit intoMiguelMadero:masterfrom
Open
Avoid errors if handler._populateQPMeta is missing#30rwjblue wants to merge 1 commit intoMiguelMadero:masterfrom
rwjblue wants to merge 1 commit intoMiguelMadero:masterfrom
Conversation
Upstream changes are removing the `_populateQPMeta` method on `Ember.Route` instances (in order to prevent the corresponding controller from being eagerly looked up). This preserves the same semantics, but avoids invocation of `handler._populageQPMeta` if it is not present.
2 tasks
Author
|
Looks like the 1.13 tests are failing, but I'm not very familiar with the test setup. Can someone take a look at the failure and provide guidance? I'm happy to fix... |
Owner
|
Wow, for someone reason I missed this almost a year ago. Thanks for opening this PR. I'll have a look. |
MiguelMadero
approved these changes
Nov 23, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upstream changes are removing the
_populateQPMetamethod onEmber.Routeinstances (in order to prevent the corresponding controller from being eagerly looked up).This preserves the same semantics, but avoids invocation of
handler._populageQPMetaif it is not present.Related PRs: