Add small home banner ad layout and update native ad references #138
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
Codex Review: Here are some suggestions.
[P1] Guard against missing native ad asset views
The new small_home_banner_native_ad.xml omits @id/ad_media and @id/ad_attribution, yet populateNativeAdView still calls adView.setMediaView(mediaView) (and later setAdvertiserView) without verifying that those views exist. When the home screen loads the small banner, both findViewById calls return null and setMediaView/setAdvertiserView throw NullPointerException, crashing ad loading. Either include those views in the small layout or skip the setter when the view lookup fails.
Reply with @codex fix comments to fix any unresolved comments.
About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you open a pull request for review, mark a draft as ready, or comment "@codex review". If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex fix this CI failure" or "@codex address that feedback".
The layout for the bottom app bar native ad was refactored to: - Use a LinearLayout as the root container instead of MaterialCardView. - Adjust padding and margins for better visual appearance. - Set a minimum width and height for the ad call-to-action button. - Change the ad container height in `activity_main.xml` to `wrap_content`.
Summary
native_adwithlarge_home_banner_native_adacross projectsmall_home_banner_native_adlayout and wrap home banner ad in a card with rounded cornersNativeAdBannerViewand loader now uselarge_home_banner_native_adTesting
./gradlew testhttps://chatgpt.com/codex/tasks/task_e_68c1b5774240832d99afc1bb8f5d8c94