Skip to content

Conversation

@MihaiCristianCondrea
Copy link
Owner

Summary

  • Rename ad and item layout XMLs for consistent ad_/item_ naming
  • Wrap bottom app bar native ad in a MaterialCardView and include ad attribution
  • Update references for renamed layouts across Java and XML resources

Testing

  • ./gradlew test (fails: SDK location not found)

https://chatgpt.com/codex/tasks/task_e_68c263f849c8832d821be5f53a3e2e8e

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codex Review: Here are some suggestions.


[P0] Adjust view binding names after layout rename

Renaming promoted_app_item.xml to item_promoted_app.xml changes the generated ViewBinding class from PromotedAppItemBinding to ItemPromotedAppBinding. HomeFragment still inflates the old binding class, so the project will fail to compile because the class name no longer exists. Update the fragment to use the new binding identifier wherever the renamed layout is inflated.


Reply with @codex fix comments to fix any unresolved comments.

About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you open a pull request for review, mark a draft as ready, or comment "@codex review". If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex fix this CI failure" or "@codex address that feedback".

- Updated lesson item icon to use ShapeableImageView with Material3 styling.
- Removed MaterialCardView from the ad layout for a flatter design.
- Adjusted padding and margins for better visual consistency.
@MihaiCristianCondrea MihaiCristianCondrea merged commit ee6b06d into main Sep 11, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants