-
Notifications
You must be signed in to change notification settings - Fork 116
Create AbstractPopMember
#505
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Benchmark Results (Julia v1)Time benchmarks
Memory benchmarks
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #505 +/- ##
==========================================
- Coverage 94.89% 94.89% -0.01%
==========================================
Files 42 42
Lines 3837 3876 +39
==========================================
+ Hits 3641 3678 +37
- Misses 196 198 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Gosh. Looking at this now. I was on the wrong branch the whole time. |
|
@MilesCranmer LGTM. Needed one extra argument and there were a couple of minor errors with the test cases. Check out #515 that needs to first be merged into this branch. And then, if it passes the entire test suite (which it now does locally on my Linux machine), we can merge into main. |
@atharvas could you please review this as soon as you get a chance?
I did it from scratch and managed to get around the type instabilities. But I want to make sure it works for LaSR.
Look at
test/test_abstract_popmember.jlfor an example implementation. Basiclaly you need to implementcreate_childfor one parent and two parents (crossover) as a way of propagating extra metadata forward. Or crossing over metadata in some way.