Create AbstractPopMember
#505
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Benchmark Results (Julia v1)Time benchmarks
Memory benchmarks
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #505 +/- ##
==========================================
- Coverage 94.89% 94.89% -0.01%
==========================================
Files 42 42
Lines 3837 3876 +39
==========================================
+ Hits 3641 3678 +37
- Misses 196 198 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Gosh. Looking at this now. I was on the wrong branch the whole time. |
This was referenced Oct 10, 2025
|
@MilesCranmer LGTM. Needed one extra argument and there were a couple of minor errors with the test cases. Check out #515 that needs to first be merged into this branch. And then, if it passes the entire test suite (which it now does locally on my Linux machine), we can merge into main. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@atharvas could you please review this as soon as you get a chance?
I did it from scratch and managed to get around the type instabilities. But I want to make sure it works for LaSR.
Look at
test/test_abstract_popmember.jlfor an example implementation. Basiclaly you need to implementcreate_childfor one parent and two parents (crossover) as a way of propagating extra metadata forward. Or crossing over metadata in some way.