Draft
Conversation
- Fix 3 kapotte kleurwaarden (missende # prefix) - Normaliseer alle #154271 typos naar #154273 - Verwijder ~20 dubbele CSS-regelblokken - Vervang NUCLEAR CSS hamburger hiding door simpele media query - Verwijder hamburger-control.js (63 regels redundante JS) - Consolideer tab hover regels (3 blokken → 1) - Vervang hardcoded kleuren door CSS variabelen in navigation.css - Ruim modal hover states op (verwijder ongewijzigde properties) - Verplaats homepage inline styles naar CSS classes - Verwijder 30+ overbodige text-align: left declaraties - Verwijder 49 !important declaraties - Fix td:hover bug in footer.css - Fix duplicate width in filters.css
Security:
- Vervang new Function() (eval) door veilige expression parser
- Voeg null check toe voor page.meta.get("id") in tags.py
- Fix deprecated datetime.utcnow() in security_txt.py
- Modal close button naar <button> met aria-label
- Voeg rel="noopener noreferrer" toe aan target="_blank" links
Deduplicatie:
- Merge extractTableDataForExcel/ODS naar extractTableData
- Merge exportToExcel/ODS naar exportToFormat
- Verwijder dubbele initializeChoices uit extra.js
- Merge generate_vereisten/maatregelen naar generieke functie
- Data-driven badge systeem in tags.py (9 functies -> config dict)
Python hooks:
- Vervang print() door logging in alle hooks
- Bouw file lookup index (O(N*M) -> O(1) lookup)
- Hernoem type/list variabelen die builtins overschaduwen
- Verwijder no-op hooks uit definities.py
- Verplaats import json naar module top
Project structuur:
- Verwijder leeg colors.html
- Update .gitignore (.DS_Store, .npm-cache/, *.pyc)
- Verwijder debug prints uit conftest.py
- Inline styles lists.py -> CSS classes
- Inline event handlers -> data-action + event delegation
- Inline SVGs -> Font Awesome icons
- Verwijder closeModal monkey-patching
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Beschrijf jouw aanpassingen
Bij welk issue hoort deze pull-request?
Checklist before requesting a review