Conversation
…ng log names
- Fix daemon error handlers in vestigingen and vestigingsprofiel: sleep(interval)
was 60x too short on error; now correctly sleeps sleep(interval * 60)
- Fix hardcoded timeout=60 in get_vestigingen_raw; use self.timeout (600s) like
all other API methods
- Add connect_args={"timeout": 30} to DB engine in vestigingen, vestigingsprofiel
and mutatie-reader to match basisprofiel and prevent indefinite hangs
- Fix copy-paste log messages in SignaalWriter, VestigingsProfielWriter and
KvKVestigingenWriter (all said "Initializing BasisProfielWriter")
- Fix f-string logging in mutatie-reader daemon loop (use lazy %s formatting)
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
vestigingen,vestigingsprofiel):time.sleep(interval)was 60× too short on error — caused rapid API-hammering after failures. Fixed totime.sleep(interval * 60).timeout=60inget_vestigingen_rawwhile all other API methods useself.timeout(600s). Fixed toself.timeout.vestigingen,vestigingsprofielandmutatie-reader: addedconnect_args={"timeout": 30}to matchbasisprofieland prevent indefinite hangs on DB outage.SignaalWriter,VestigingsProfielWriterandKvKVestigingenWriterall logged"Initializing BasisProfielWriter". Fixed to correct class names.mutatie-readerdaemon loop: replaced with lazy%sformatting per coding standards.Test plan
just check-allpasses (190 tests, 0 pyright errors, ruff clean)🤖 Generated with Claude Code